Skip to content

fix(@angular/cli): validate package manager version using semver.valid and throw an error if invalid #32524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Feb 20, 2026
Merged

fix(@angular/cli): validate package manager version using semver.valid and throw an error if invalid #32524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28c1527
fix(@angular/cli): validate package manager version using `semver.val…
alan-agius4 Feb 20, 2026
fe3c851
fixup! fix(@angular/cli): validate package manager version using `sem…
alan-agius4 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/angular/cli/src/package-managers/package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import { join, relative, resolve } from 'node:path';
import npa from 'npm-package-arg';
import { maxSatisfying } from 'semver';
import { maxSatisfying, valid } from 'semver';
import { PackageManagerError } from './error';
import { Host } from './host';
import { Logger } from './logger';
Expand Down Expand Up @@ -370,6 +370,10 @@ export class PackageManager {
const { stdout } = await this.#run(this.descriptor.versionCommand);
this.#version = stdout.trim();

if (!valid(this.#version)) {
throw new Error(`Invalid semver version for ${this.name}: ${this.#version}`);
Comment thread
alan-agius4 marked this conversation as resolved.
Outdated
}

return this.#version;
}

Expand Down
Loading