test(aria/accordion): generate additional tests for Accordion directives and patterns

Author: adolgachev

src/aria/accordion/accordion.spec.ts

@@ -293,23 +293,23 @@ describe('AccordionGroup', () => {
       });
 
       it('should update collection order when items are shuffled', async () => {
-        const groupDebugElement = fixture.debugElement.query(By.directive(AccordionGroup));
-        const groupDirective = groupDebugElement.injector.get(AccordionGroup);
-
-        let orderedItems = groupDirective._collection.orderedItems();
-        expect(orderedItems.length).toBe(3);
-        expect(orderedItems[0].element.textContent?.trim()).toBe('Item 1 Header');
-        expect(orderedItems[2].element.textContent?.trim()).toBe('Item 3 Header');
+        // Verify initial DOM order
+        expect(triggerElements.length).toBe(3);
+        expect(triggerElements[0].textContent?.trim()).toBe('Item 1 Header');
+        expect(triggerElements[2].textContent?.trim()).toBe('Item 3 Header');
 
+        // Shuffle (reverse) data
         const items = testComponent.items().reverse();
         testComponent.items.set([...items]);
         fixture.detectChanges();
         await waitForMicrotasks();
 
-        orderedItems = groupDirective._collection.orderedItems();
-        expect(orderedItems.length).toBe(3);
-        expect(orderedItems[0].element.textContent?.trim()).toBe('Item 3 Header');
-        expect(orderedItems[2].element.textContent?.trim()).toBe('Item 1 Header');
+        // Re-query elements to check new DOM order
+        setupTriggerAndPanels();
+
+        expect(triggerElements.length).toBe(3);
+        expect(triggerElements[0].textContent?.trim()).toBe('Item 3 Header');
+        expect(triggerElements[2].textContent?.trim()).toBe('Item 1 Header');
       });
 
       describe('wrap behavior', () => {

src/aria/private/accordion/accordion.spec.ts

@@ -322,5 +322,49 @@ describe('Accordion Pattern', () => {
         expect(triggerPatterns[1].expanded()).toBeTrue();
       });
     });
+
+    describe('AccordionTriggerPattern methods', () => {
+      it('should expand via open()', () => {
+        expect(triggerPatterns[0].expanded()).toBeFalse();
+        triggerPatterns[0].open();
+        expect(triggerPatterns[0].expanded()).toBeTrue();
+      });
+
+      it('should collapse via close()', () => {
+        triggerPatterns[0].expanded.set(true);
+        expect(triggerPatterns[0].expanded()).toBeTrue();
+        triggerPatterns[0].close();
+        expect(triggerPatterns[0].expanded()).toBeFalse();
+      });
+
+      it('should toggle via toggle()', () => {
+        expect(triggerPatterns[0].expanded()).toBeFalse();
+        triggerPatterns[0].toggle();
+        expect(triggerPatterns[0].expanded()).toBeTrue();
+
+        triggerPatterns[0].toggle();
+        expect(triggerPatterns[0].expanded()).toBeFalse();
+      });
+    });
+
+    describe('softDisabled behavior', () => {
+      it('should compute hardDisabled as true when disabled=true and softDisabled=false', () => {
+        triggerInputs[0].disabled.set(true);
+        groupInputs.softDisabled.set(false);
+        expect(triggerPatterns[0].hardDisabled()).toBeTrue();
+      });
+
+      it('should compute hardDisabled as false when disabled=true and softDisabled=true', () => {
+        triggerInputs[0].disabled.set(true);
+        groupInputs.softDisabled.set(true);
+        expect(triggerPatterns[0].hardDisabled()).toBeFalse();
+      });
+
+      it('should compute hardDisabled as false when disabled=false', () => {
+        triggerInputs[0].disabled.set(false);
+        groupInputs.softDisabled.set(false);
+        expect(triggerPatterns[0].hardDisabled()).toBeFalse();
+      });
+    });
   });
 });