fixup! refactor(multiple): migrate Listbox and Tabs to ClickEventManager

Author: ok7sai

src/aria/private/behaviors/event-manager/click-event-manager.ts

@@ -15,6 +15,20 @@ import {
   Modifier,
 } from './event-manager';
 
+/**
+ * Gets whether an event could be a faked click event dispatched by a screen reader
+ * or generated by the browser when Enter or Space keys are pressed.
+ */
+export function isFakeClick(event: PointerEvent): boolean {
+  // Some screen readers will dispatch a fake click event when pressing enter or space on
+  // a clickable element. We can distinguish these events when `event.buttons` is zero, or
+  // `event.detail` is zero depending on the browser:
+  // - `event.buttons` works on Firefox, but fails on Chrome.
+  // - `detail` works on Chrome, but fails on Firefox.
+  // Also, fake events might not have a valid pointerType.
+  return event.buttons === 0 || event.detail === 0 || !event.pointerType;
+}
+
 /**
  * An event manager that is specialized for handling click events.
  *
@@ -67,19 +81,6 @@ export class ClickEventManager<T extends PointerEvent> extends EventManager<T> {
   }
 
   _isMatch(event: T, modifiers: ModifierInputs) {
-    return this._isRealClick(event) && hasModifiers(event, modifiers);
-  }
-
-  /**
-   * Checks if the event is a "real" pointer click.
-   *
-   * Real clicks typically have a non-zero detail count (click count) and
-   * a valid pointerType (e.g. 'mouse' or 'touch').
-   */
-  private _isRealClick(event: T): boolean {
-    if (event.detail === 0) return false;
-    if (event.clientX === 0 && event.clientY === 0) return false;
-    if (!event.pointerType) return false;
-    return true;
+    return !isFakeClick(event) && hasModifiers(event, modifiers);
   }
 }