Skip to content

Commit 7116254

Browse files
committed
refactor(multiple): use write stage for setDefaultStateEffect across all aria directives
1 parent f260b88 commit 7116254

5 files changed

Lines changed: 6 additions & 15 deletions

File tree

src/aria/listbox/listbox.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,7 @@ export class Listbox<V> {
167167
}
168168
});
169169

170-
afterRenderEffect(() => {
171-
this._pattern.setDefaultStateEffect();
172-
});
170+
afterRenderEffect({write: () => this._pattern.setDefaultStateEffect()});
173171

174172
// Ensure that if the active item is removed from
175173
// the list, the listbox updates it's focus state.

src/aria/menu/menu-bar.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,7 @@ export class MenuBar<V> {
123123
element: computed(() => this._elementRef.nativeElement),
124124
});
125125

126-
afterRenderEffect(() => {
127-
this._pattern.setDefaultStateEffect();
128-
});
126+
afterRenderEffect({write: () => this._pattern.setDefaultStateEffect()});
129127
}
130128

131129
/** Closes the menubar. */

src/aria/menu/menu.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,7 @@ export class Menu<V> {
187187
},
188188
});
189189

190-
afterRenderEffect(() => {
191-
this._pattern.setDefaultStateEffect();
192-
});
190+
afterRenderEffect({write: () => this._pattern.setDefaultStateEffect()});
193191
}
194192

195193
/** Closes the menu. */

src/aria/toolbar/toolbar.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,7 @@ export class Toolbar<V> {
105105
});
106106

107107
constructor() {
108-
afterRenderEffect(() => {
109-
this._pattern.setDefaultStateEffect();
110-
});
108+
afterRenderEffect({write: () => this._pattern.setDefaultStateEffect()});
111109
}
112110

113111
_register(widget: ToolbarWidget<V>) {

src/aria/tree/tree.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,8 @@ export class Tree<V> {
179179
}
180180
});
181181

182-
afterRenderEffect(() => {
183-
this._pattern.setDefaultStateEffect();
184-
});
182+
// Resets default focus based on selection state until interacted.
183+
afterRenderEffect({write: () => this._pattern.setDefaultStateEffect()});
185184

186185
afterRenderEffect(() => {
187186
const items = inputs.items();

0 commit comments

Comments
 (0)