Skip to content

Commit 8bc245b

Browse files
committed
docs: remove OnPush from examples
Updates all the examples to remove the explicit `OnPush` change detection since it's the default.
1 parent 9650318 commit 8bc245b

116 files changed

Lines changed: 111 additions & 288 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/components-examples/aria/autocomplete/autocomplete-auto-select/autocomplete-auto-select-example.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,7 @@
88

99
import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
11-
import {
12-
afterRenderEffect,
13-
ChangeDetectionStrategy,
14-
Component,
15-
computed,
16-
signal,
17-
viewChild,
18-
} from '@angular/core';
11+
import {afterRenderEffect, Component, computed, signal, viewChild} from '@angular/core';
1912
import {COUNTRIES} from '../countries';
2013
import {OverlayModule} from '@angular/cdk/overlay';
2114
import {FormsModule} from '@angular/forms';
@@ -26,7 +19,6 @@ import {FormsModule} from '@angular/forms';
2619
templateUrl: 'autocomplete-auto-select-example.html',
2720
styleUrl: '../autocomplete.css',
2821
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule, FormsModule],
29-
changeDetection: ChangeDetectionStrategy.OnPush,
3022
})
3123
export class AutocompleteAutoSelectExample {
3224
/** The selected value of the combobox. */

src/components-examples/aria/autocomplete/autocomplete-disabled/autocomplete-disabled-example.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,7 @@
88

99
import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
11-
import {
12-
afterRenderEffect,
13-
ChangeDetectionStrategy,
14-
Component,
15-
computed,
16-
signal,
17-
viewChild,
18-
} from '@angular/core';
11+
import {afterRenderEffect, Component, computed, signal, viewChild} from '@angular/core';
1912
import {COUNTRIES} from '../countries';
2013
import {OverlayModule} from '@angular/cdk/overlay';
2114
import {FormsModule} from '@angular/forms';
@@ -26,7 +19,6 @@ import {FormsModule} from '@angular/forms';
2619
templateUrl: 'autocomplete-disabled-example.html',
2720
styleUrl: '../autocomplete.css',
2821
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule, FormsModule],
29-
changeDetection: ChangeDetectionStrategy.OnPush,
3022
})
3123
export class AutocompleteDisabledExample {
3224
/** The selected value of the combobox. */

src/components-examples/aria/autocomplete/autocomplete-highlight/autocomplete-highlight-example.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,7 @@
88

99
import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
11-
import {
12-
afterRenderEffect,
13-
ChangeDetectionStrategy,
14-
Component,
15-
computed,
16-
effect,
17-
signal,
18-
viewChild,
19-
} from '@angular/core';
11+
import {afterRenderEffect, Component, computed, effect, signal, viewChild} from '@angular/core';
2012
import {COUNTRIES} from '../countries';
2113
import {OverlayModule} from '@angular/cdk/overlay';
2214
import {FormsModule} from '@angular/forms';
@@ -27,7 +19,6 @@ import {FormsModule} from '@angular/forms';
2719
templateUrl: 'autocomplete-highlight-example.html',
2820
styleUrl: '../autocomplete.css',
2921
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule, FormsModule],
30-
changeDetection: ChangeDetectionStrategy.OnPush,
3122
})
3223
export class AutocompleteHighlightExample {
3324
/** The selected value of the combobox. */

src/components-examples/aria/autocomplete/autocomplete-manual/autocomplete-manual-example.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,7 @@
88

99
import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
11-
import {
12-
afterRenderEffect,
13-
ChangeDetectionStrategy,
14-
Component,
15-
computed,
16-
signal,
17-
viewChild,
18-
} from '@angular/core';
11+
import {afterRenderEffect, Component, computed, signal, viewChild} from '@angular/core';
1912
import {COUNTRIES} from '../countries';
2013
import {OverlayModule} from '@angular/cdk/overlay';
2114
import {FormsModule} from '@angular/forms';
@@ -26,7 +19,6 @@ import {FormsModule} from '@angular/forms';
2619
templateUrl: 'autocomplete-manual-example.html',
2720
styleUrl: '../autocomplete.css',
2821
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule, FormsModule],
29-
changeDetection: ChangeDetectionStrategy.OnPush,
3022
})
3123
export class AutocompleteManualExample {
3224
/** The selected value of the combobox. */

src/components-examples/aria/combobox/combobox-dialog/combobox-dialog-example.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
1111
import {
1212
afterRenderEffect,
13-
ChangeDetectionStrategy,
1413
Component,
1514
computed,
1615
signal,
@@ -27,7 +26,6 @@ import {FormsModule} from '@angular/forms';
2726
templateUrl: 'combobox-dialog-example.html',
2827
styleUrls: ['../combobox-example.css'],
2928
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule, FormsModule],
30-
changeDetection: ChangeDetectionStrategy.OnPush,
3129
})
3230
export class ComboboxDialogExample {
3331
listbox = viewChild<Listbox<string>>(Listbox);

src/components-examples/aria/combobox/combobox-editable-multiselect/combobox-editable-multiselect-example.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
1111
import {
1212
afterRenderEffect,
13-
ChangeDetectionStrategy,
1413
Component,
1514
computed,
1615
signal,
@@ -28,7 +27,6 @@ import {FormsModule} from '@angular/forms';
2827
templateUrl: 'combobox-editable-multiselect-example.html',
2928
styleUrl: '../combobox-example.css',
3029
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule, FormsModule],
31-
changeDetection: ChangeDetectionStrategy.OnPush,
3230
})
3331
export class ComboboxEditableMultiselectExample {
3432
readonly listbox = viewChild(Listbox);

src/components-examples/aria/combobox/combobox-multiselect-dialog/combobox-multiselect-dialog-example.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
1111
import {
1212
afterRenderEffect,
13-
ChangeDetectionStrategy,
1413
Component,
1514
computed,
1615
signal,
@@ -28,7 +27,6 @@ import {FormsModule} from '@angular/forms';
2827
templateUrl: 'combobox-multiselect-dialog-example.html',
2928
styleUrl: '../combobox-example.css',
3029
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule, FormsModule],
31-
changeDetection: ChangeDetectionStrategy.OnPush,
3230
})
3331
export class ComboboxMultiselectDialogExample {
3432
readonly listbox = viewChild(Listbox);

src/components-examples/aria/combobox/combobox-readonly-disabled/combobox-readonly-disabled-example.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,7 @@
88

99
import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
11-
import {
12-
afterRenderEffect,
13-
ChangeDetectionStrategy,
14-
Component,
15-
signal,
16-
viewChild,
17-
} from '@angular/core';
11+
import {afterRenderEffect, Component, signal, viewChild} from '@angular/core';
1812
import {OverlayModule} from '@angular/cdk/overlay';
1913

2014
/** @title Disabled readonly combobox. */
@@ -23,7 +17,6 @@ import {OverlayModule} from '@angular/cdk/overlay';
2317
templateUrl: 'combobox-readonly-disabled-example.html',
2418
styleUrl: '../combobox-select/combobox-select-example.css',
2519
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule],
26-
changeDetection: ChangeDetectionStrategy.OnPush,
2720
})
2821
export class ComboboxReadonlyDisabledExample {
2922
readonly listbox = viewChild(Listbox);

src/components-examples/aria/combobox/combobox-readonly-multiselect/combobox-readonly-multiselect-example.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,7 @@
88

99
import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Listbox, Option} from '@angular/aria/listbox';
11-
import {
12-
afterRenderEffect,
13-
ChangeDetectionStrategy,
14-
Component,
15-
computed,
16-
signal,
17-
viewChild,
18-
} from '@angular/core';
11+
import {afterRenderEffect, Component, computed, signal, viewChild} from '@angular/core';
1912
import {OverlayModule} from '@angular/cdk/overlay';
2013

2114
/** @title Readonly multiselectable combobox. */
@@ -24,7 +17,6 @@ import {OverlayModule} from '@angular/cdk/overlay';
2417
templateUrl: 'combobox-readonly-multiselect-example.html',
2518
styleUrl: '../combobox-select/combobox-select-example.css',
2619
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option, OverlayModule],
27-
changeDetection: ChangeDetectionStrategy.OnPush,
2820
})
2921
export class ComboboxReadonlyMultiselectExample {
3022
readonly listbox = viewChild(Listbox);

src/components-examples/aria/combobox/combobox-tree-auto-select/combobox-tree-auto-select-example.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,7 @@
88

99
import {Combobox, ComboboxPopup, ComboboxWidget} from '@angular/aria/combobox';
1010
import {Tree, TreeItem, TreeItemGroup} from '@angular/aria/tree';
11-
import {
12-
Component,
13-
afterRenderEffect,
14-
computed,
15-
signal,
16-
viewChild,
17-
untracked,
18-
ChangeDetectionStrategy,
19-
} from '@angular/core';
11+
import {Component, afterRenderEffect, computed, signal, viewChild, untracked} from '@angular/core';
2012
import {NgTemplateOutlet} from '@angular/common';
2113
import {OverlayModule} from '@angular/cdk/overlay';
2214

@@ -41,7 +33,6 @@ interface SeasonNode {
4133
TreeItemGroup,
4234
OverlayModule,
4335
],
44-
changeDetection: ChangeDetectionStrategy.OnPush,
4536
})
4637
export class ComboboxTreeAutoSelectExample {
4738
readonly tree = viewChild(Tree);

0 commit comments

Comments
 (0)