build: rename common tests file

Renames the file with common harness tests not to include `.spec.ts` since it can get picked up as a test by accident.

Author: crisbeto

src/cdk/testing/tests/BUILD.bazel

@@ -9,6 +9,7 @@ ng_project(
         ["**/*.ts"],
         exclude = [
             "**/*.spec.ts",
+            "cross-environment-tests.ts",
             "harnesses/**",
         ],
     ),
@@ -30,9 +31,9 @@ ts_project(
 )
 
 ts_project(
-    name = "cross_environment_specs",
+    name = "cross_environment_tests",
     testonly = True,
-    srcs = ["cross-environment.spec.ts"],
+    srcs = ["cross-environment-tests.ts"],
     deps = [
         ":test_harnesses",
         "//:node_modules/@angular/core",
@@ -48,12 +49,11 @@ ng_project(
             "**/*.spec.ts",
         ],
         exclude = [
-            "cross-environment.spec.ts",
             "**/*.e2e.spec.ts",
         ],
     ),
     deps = [
-        ":cross_environment_specs",
+        ":cross_environment_tests",
         ":test_components",
         ":test_harnesses",
         "//:node_modules/@angular/core",
@@ -76,7 +76,7 @@ ts_project(
         exclude = ["webdriver.e2e.spec.ts"],
     ),
     deps = [
-        ":cross_environment_specs",
+        ":cross_environment_tests",
         ":test_harnesses",
         "//:node_modules/protractor",
         "//src/cdk/testing",
@@ -90,7 +90,7 @@ ts_project(
     testonly = True,
     srcs = ["webdriver.e2e.spec.ts"],
     deps = [
-        ":cross_environment_specs",
+        ":cross_environment_tests",
         ":test_harnesses",
         "//:node_modules/@bazel/runfiles",
         "//:node_modules/@types/jasmine",

…/testing/tests/cross-environment.spec.ts …testing/tests/cross-environment-tests.tssrc/cdk/testing/tests/cross-environment.spec.ts renamed to src/cdk/testing/tests/cross-environment-tests.ts src/cdk/testing/tests/cross-environment.spec.ts renamed to src/cdk/testing/tests/cross-environment-tests.ts

@@ -2,7 +2,7 @@ import {HarnessLoader} from '../../testing';
 import {ProtractorHarnessEnvironment} from '../../testing/protractor';
 import {browser, by, element as protractorElement, ElementFinder} from 'protractor';
 import {parallel} from '../change-detection';
-import {crossEnvironmentSpecs} from './cross-environment.spec';
+import {crossEnvironmentSpecs} from './cross-environment-tests';
 import {MainComponentHarness} from './harnesses/main-component-harness';
 
 // Kagekiri is available globally in the browser. We declare it here so we can use it in the

src/cdk/testing/tests/protractor.e2e.spec.ts

@@ -21,6 +21,6 @@ import {ChangeDetectionStrategy, Component, Input, ViewEncapsulation} from '@ang
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class TestSubComponent {
-  @Input() title: string;
-  @Input() items: string[];
+  @Input() title = '';
+  @Input() items: string[] = [];
 }

src/cdk/testing/tests/test-sub-component.ts

@@ -4,7 +4,7 @@ import {TestbedHarnessEnvironment} from '../../testing/testbed';
 import {waitForAsync, ComponentFixture, fakeAsync, TestBed} from '@angular/core/testing';
 import {provideZoneChangeDetection} from '@angular/core';
 import {querySelectorAll as piercingQuerySelectorAll} from 'kagekiri';
-import {crossEnvironmentSpecs} from './cross-environment.spec';
+import {crossEnvironmentSpecs} from './cross-environment-tests';
 import {FakeOverlayHarness} from './harnesses/fake-overlay-harness';
 import {MainComponentHarness} from './harnesses/main-component-harness';
 import {TestMainComponent} from './test-main-component';

src/cdk/testing/tests/testbed.spec.ts

@@ -4,7 +4,7 @@ import {
   waitForAngularReady,
 } from '../../testing/selenium-webdriver';
 import * as webdriver from 'selenium-webdriver';
-import {crossEnvironmentSpecs} from './cross-environment.spec';
+import {crossEnvironmentSpecs} from './cross-environment-tests';
 import {MainComponentHarness} from './harnesses/main-component-harness';
 import {Options, setDefaultService, ServiceBuilder} from 'selenium-webdriver/chrome';
 import path from 'path';