fix(multiple): wrap ngDevMode check around afterRenderEffect in aria primitives#32717
Closed
OmerGronich wants to merge 1 commit intoangular:mainfrom
Closed
fix(multiple): wrap ngDevMode check around afterRenderEffect in aria primitives#32717OmerGronich wants to merge 1 commit intoangular:mainfrom
OmerGronich wants to merge 1 commit intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…primitives Moving the ngDevMode check outside of afterRenderEffect ensures the effect is not registered at all in production, rather than registering an effect that does nothing. Affected packages: aria/listbox, aria/toolbar
OmerGronich
force-pushed
the
fix-ngdevmode-aria-primitives
branch
from
1243d85 to
1f27d70
Compare
Contributor
|
This draft PR is being closed because it has been stale for 28 days and has seen no activity from you. If you'd like to see this change land, you can re-open this PR. Thank you for being an Angular contributor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ngDevModecheck outside ofafterRenderEffectinaria/listboxandaria/toolbarFollow-up to feedback from #32663
🤖 Generated with Claude Code