refactor(multiple): rework LabelControl across aria components#33146
Open
adolgachev wants to merge 3 commits intoangular:mainfrom
Open
refactor(multiple): rework LabelControl across aria components#33146adolgachev wants to merge 3 commits intoangular:mainfrom
adolgachev wants to merge 3 commits intoangular:mainfrom
Conversation
angular-robot
Bot
added
detected: feature
adolgachev
added
dev-app preview
|
Deployed dev-app for a867429 to: https://ng-dev-previews-comp--pr-angular-components-33146-dev-qadmum20.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
aria-labels
branch
5 times, most recently
from
3082e63 to
bad3cc9
Compare
ok7sai
reviewed
Apr 28, 2026
Member
There was a problem hiding this comment.
Can we stop the "I want this in my own style" kind of refactoring? I don't see the core functionality has changed after touching almost every single line.
| }); | ||
|
|
||
| constructor() { | ||
| this._labelControl = new LabelControl({ |
Member
There was a problem hiding this comment.
We should put this in the UI pattern to keep the directive a thin layer between the framework and the core library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors to make LabelControl easier to use by directives directly:
Added proper usage to AccordionPanel and TabPanel so default labelledby still set properly to the respective AccordionTrigger or Tab, but also could be overridden. Although not recommended to do so.