feat(google-maps): Add support for the gmp-click event#33147
Merged
andrewseguin merged 1 commit intoangular:mainfrom Apr 24, 2026
Merged
feat(google-maps): Add support for the gmp-click event#33147andrewseguin merged 1 commit intoangular:mainfrom
andrewseguin merged 1 commit intoangular:mainfrom
Conversation
angular-robot
Bot
added
detected: feature
andrewseguin
approved these changes
Apr 24, 2026
Add an output to proxy the gmp-click event and an input for gmpClickable which is set on the AdvancedMarkerElement. Everything is the same pattern as gmpDrag Fixes #33145
jermowery
force-pushed
the
fix-advanced-marker
branch
from
129fb4a to
fa1d475
Compare
crisbeto
reviewed
Apr 24, 2026
| * @see https://developers.google.com/maps/documentation/javascript/reference/advanced-markers#AdvancedMarkerElementOptions.gmpClickable | ||
| */ | ||
| @Input() | ||
| set gmpClickable(clickable: boolean) { |
Member
There was a problem hiding this comment.
Should we set this automatically if gmpClick is bound?
Contributor
Author
There was a problem hiding this comment.
We don't for any of the drag events ¯\_(ツ)_/¯
I think the API could use a bit of an overhaul, especially since the underlying Google Maps API has changed since this was written. Probably would be best to do that as a separate thing
Contributor
Author
andrewseguin
added
action: merge
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an output to proxy the gmp-click event and an input for gmpClickable which is set on the AdvancedMarkerElement. Everything is the same pattern as gmpDrag
Fixes #33145