refactor(aria/tabs): remove unnecessary LabelControl usage

[adolgachev]

Remove unnecessary usage of LabelControl in Tab pattern. It doesn't help if just used for setting aria-labelledby as just a lot of redirection to accomplish the same thing.

See #33146 for subsequent work to make LabelControl easier to use, and then to actually use it for the full usage allowing users of the directives to supply custom aria-labelledby or aria-label.

[ok7sai]

I don't understand why remove it instead of just reworking the LabelControl and properly bind to the directive.

[adolgachev]

I don't understand why remove it instead of just reworking the LabelControl and properly bind to the directive.

See the PR notes. I have a PR for that but easier to just remove the usage first as it has no benefit. Then we can discuss the approach and not have this single unnecessary usage get in the way of reworking it.

[ok7sai]

I see the PR note but I don't see a reworked LabelControl other than changing the defaultLabelledBy type from string[] to string | undefined. What's the plan? It would be better to include both the reworked LabelControl along with the updated Tabs usage as a POC for the reworked version.

[ok7sai]

Since you created a CL already feel free to remove it.

[adolgachev]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 13c92a3