Skip to content

docs(aria/toolbar): Add another example for simple-combobox within the toolbar #33173

Merged
tjshiu merged 1 commit intoangular:mainfrom
tjshiu:simple-combobox-toolbar
Apr 30, 2026
Merged

docs(aria/toolbar): Add another example for simple-combobox within the toolbar #33173
tjshiu merged 1 commit intoangular:mainfrom
tjshiu:simple-combobox-toolbar

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented Apr 30, 2026

refactored the toolbar to use simple-combobox instead.

@tjshiu tjshiu marked this pull request as draft April 30, 2026 04:49
@tjshiu tjshiu force-pushed the simple-combobox-toolbar branch from 3a2ad68 to eb69e17 Compare April 30, 2026 05:10
@tjshiu tjshiu marked this pull request as ready for review April 30, 2026 05:14
@tjshiu tjshiu requested review from crisbeto and ok7sai April 30, 2026 05:15
@tjshiu tjshiu added target: major This PR is targeted for the next major release dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Apr 30, 2026
@github-actions
Copy link
Copy Markdown

Deployed dev-app for eb69e17 to: https://ng-dev-previews-comp--pr-angular-components-33173-dev-uq4a9nqz.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Copy Markdown
Member

@ok7sai ok7sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The PR label should be docs instead of refactor.

@tjshiu tjshiu changed the title refactor(aria/toolbar): Add another example for simple-combobox within the toolbar docs(aria/toolbar): Add another example for simple-combobox within the toolbar Apr 30, 2026
@tjshiu tjshiu added the action: merge The PR is ready for merge by the caretaker label Apr 30, 2026
@tjshiu tjshiu merged commit d1b075b into angular:main Apr 30, 2026
34 checks passed
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented Apr 30, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: aria/toolbar dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants