Skip to content

docs(aria/combobox): update the simple-combobox examples to open on click#33184

Merged
tjshiu merged 2 commits intoangular:mainfrom
tjshiu:click
May 1, 2026
Merged

docs(aria/combobox): update the simple-combobox examples to open on click#33184
tjshiu merged 2 commits intoangular:mainfrom
tjshiu:click

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented May 1, 2026

All Examples open on click now

@pullapprove pullapprove Bot requested review from crisbeto and wagnermaciel May 1, 2026 04:45
@angular-robot angular-robot Bot added area: docs Related to the documentation area: aria/combobox labels May 1, 2026
@tjshiu tjshiu requested review from adolgachev and ok7sai May 1, 2026 04:45
@tjshiu tjshiu added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label May 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Deployed dev-app for fd6f2c2 to: https://ng-dev-previews-comp--pr-angular-components-33184-dev-l03c2vbg.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@tjshiu tjshiu added the action: merge The PR is ready for merge by the caretaker label May 1, 2026
@ok7sai
Copy link
Copy Markdown
Member

ok7sai commented May 1, 2026

One small catch is the combobox with highlight fills the input upon click which is a bit weird.

@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 1, 2026

Thanks - I updated it so that it also updates the highlighted text as you navigate.

@tjshiu tjshiu added the target: major This PR is targeted for the next major release label May 1, 2026
@tjshiu tjshiu merged commit 3c6f299 into angular:main May 1, 2026
27 checks passed
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 1, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@tjshiu tjshiu deleted the click branch May 1, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: aria/combobox area: docs Related to the documentation dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants