Skip to content

docs(aria/combobox): add no results when there are no results from filtering #33188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjshiu merged 1 commit into from
May 2, 2026
Merged

docs(aria/combobox): add no results when there are no results from filtering #33188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...aria/simple-combobox/simple-combobox-auto-select/simple-combobox-auto-select-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,28 @@
[(value)]="searchString" [(expanded)]="popupExpanded" (click)="popupExpanded.set(true)" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{options().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
[cdkConnectedOverlayDisableClose]="true">
<ng-template ngComboboxPopup [combobox]="combobox">
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox example-popup" focusMode="activedescendant"
<div class="example-popup">
@if (options().length === 0) {
<div class="example-no-results">No results found</div>
}
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox" focusMode="activedescendant"
[tabindex]="-1" [(value)]="selectedOption" (click)="onCommit()" (keydown.enter)="onCommit()"
[activeDescendant]="listbox.activeDescendant()">
[activeDescendant]="listbox.activeDescendant()"
[class.example-empty]="options().length === 0">
@for (option of options(); track option) {
<div class="example-option example-selectable example-stateful" ngOption [value]="option" [label]="option">
<span>{{option}}</span>
<span aria-hidden="true" class="material-symbols-outlined example-icon example-selected-icon">check</span>
</div>
}
</div>
</div>
</ng-template>
</ng-template>
Expand Down
31 changes: 21 additions & 10 deletions ...-examples/aria/simple-combobox/simple-combobox-dialog/simple-combobox-dialog-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,29 @@
placeholder="Search..." [(ngModel)]="searchString" [alwaysExpanded]="true"
(keydown.escape)="onSearchEscape($event)" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{options().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template ngComboboxPopup [combobox]="innerCombobox">
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox" focusMode="activedescendant"
tabindex="-1" selectionMode="explicit" [(value)]="selectedStates" (click)="onCommit()"
(keydown.enter)="onCommit()" [activeDescendant]="listbox.activeDescendant()">
@for (option of options(); track option) {
<div class="example-option example-selectable example-stateful" ngOption [value]="option"
[label]="option">
<span>{{option}}</span>
<span aria-hidden="true"
class="material-symbols-outlined example-icon example-selected-icon">check</span>
</div>
<div class="example-popup example-popup-no-margin">
@if (options().length === 0) {
<div class="example-no-results">No results found</div>
}
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox" focusMode="activedescendant"
tabindex="-1" selectionMode="explicit" [(value)]="selectedStates" (click)="onCommit()"
(keydown.enter)="onCommit()" [activeDescendant]="listbox.activeDescendant()"
[class.example-empty]="options().length === 0">
@for (option of options(); track option) {
<div class="example-option example-selectable example-stateful" ngOption [value]="option"
[label]="option">
<span>{{option}}</span>
<span aria-hidden="true"
class="material-symbols-outlined example-icon example-selected-icon">check</span>
</div>
}
</div>
</div>
</ng-template>
</div>
Expand Down
17 changes: 17 additions & 0 deletions src/components-examples/aria/simple-combobox/simple-combobox-example.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,3 +360,20 @@ ul[role='group'] {
.example-grid-row[aria-selected='true'] .example-selected-icon {
visibility: visible;
}

.example-no-results {
padding: 1rem;
}

.example-empty {
position: absolute;
visibility: hidden;
pointer-events: none;
height: 0;
width: 0;
overflow: hidden;
}

.example-popup-no-margin {
margin-block-start: 0;
}
45 changes: 27 additions & 18 deletions ...ents-examples/aria/simple-combobox/simple-combobox-grid/simple-combobox-grid-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,38 @@
[(value)]="searchString" [(expanded)]="popupExpanded" (blur)="onBlur()" (click)="popupExpanded.set(true)" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{filteredItems().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
[cdkConnectedOverlayDisableClose]="true">
<ng-template ngComboboxPopup [combobox]="combobox">
<div ngComboboxWidget ngGrid focusMode="activedescendant" [tabindex]="-1" class="example-popup"
colWrap="continuous" #grid="ngGrid" [activeDescendant]="grid.activeDescendant()">
@for (item of filteredItems(); track item.label; let i = $index) {
<div ngGridRow class="example-grid-row" [attr.aria-selected]="item === selectedItem()">
<div ngGridCell [id]="item.label + '-label'" [rowIndex]="i" [colIndex]="0"
class="example-cell-label example-cell" (activated)="selectItem(item)">
<button ngGridCellWidget class="example-label-button example-no-active-outline" (click)="selectItem(item)">
{{item.label}}
</button>
<mat-icon class="example-selected-icon">check</mat-icon>
</div>
<div ngGridCell [id]="item.label + '-delete'" [rowIndex]="i" [colIndex]="1"
class="example-cell-button example-cell " (activated)="removeItem(item)">
<button ngGridCellWidget class="example-button example-no-active-outline" (click)="removeItem(item)"
(pointerdown)="$event.preventDefault()">
<mat-icon>close</mat-icon>
</button>
<div class="example-popup">
@if (filteredItems().length === 0) {
<div class="example-no-results">No results found</div>
}
<div ngComboboxWidget ngGrid focusMode="activedescendant" [tabindex]="-1"
colWrap="continuous" #grid="ngGrid" [activeDescendant]="grid.activeDescendant()">
@for (item of filteredItems(); track item.label; let i = $index) {
<div ngGridRow class="example-grid-row" [attr.aria-selected]="item === selectedItem()">
<div ngGridCell [id]="item.label + '-label'" [rowIndex]="i" [colIndex]="0"
class="example-cell-label example-cell" (activated)="selectItem(item)">
<button ngGridCellWidget class="example-label-button example-no-active-outline" (click)="selectItem(item)">
{{item.label}}
</button>
<mat-icon class="example-selected-icon">check</mat-icon>
</div>
<div ngGridCell [id]="item.label + '-delete'" [rowIndex]="i" [colIndex]="1"
class="example-cell-button example-cell " (activated)="removeItem(item)">
<button ngGridCellWidget class="example-button example-no-active-outline" (click)="removeItem(item)"
(pointerdown)="$event.preventDefault()">
<mat-icon>close</mat-icon>
</button>
</div>
</div>
}
</div>
}
</div>
</ng-template>
</ng-template>
Expand Down
28 changes: 19 additions & 9 deletions ...les/aria/simple-combobox/simple-combobox-highlight/simple-combobox-highlight-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,29 @@
[inlineSuggestion]="(searchString() || navigated()) ? selectedOption()[0] : undefined" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{options().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
[cdkConnectedOverlayDisableClose]="true">
<ng-template ngComboboxPopup [combobox]="combobox">
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox example-popup"
focusMode="activedescendant" [tabindex]="-1" [(value)]="selectedOption" (click)="onCommit()"
(keydown.enter)="onCommit()" [activeDescendant]="listbox.activeDescendant()">
@for (option of options(); track option.name) {
<div class="example-option example-selectable example-stateful" ngOption [value]="option.name"
[label]="option.name" [disabled]="option.disabled">
<span>{{option.name}}</span>
<span aria-hidden="true" class="material-symbols-outlined example-icon example-selected-icon">check</span>
</div>
<div class="example-popup">
@if (options().length === 0) {
<div class="example-no-results">No results found</div>
}
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox"
focusMode="activedescendant" [tabindex]="-1" [(value)]="selectedOption" (click)="onCommit()"
(keydown.enter)="onCommit()" [activeDescendant]="listbox.activeDescendant()"
[class.example-empty]="options().length === 0">
@for (option of options(); track option.name) {
<div class="example-option example-selectable example-stateful" ngOption [value]="option.name"
[label]="option.name" [disabled]="option.disabled">
<span>{{option.name}}</span>
<span aria-hidden="true" class="material-symbols-outlined example-icon example-selected-icon">check</span>
</div>
}
</div>
</div>
</ng-template>
</ng-template>
Expand Down
26 changes: 18 additions & 8 deletions ...xamples/aria/simple-combobox/simple-combobox-listbox/simple-combobox-listbox-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,28 @@
[(value)]="searchString" [(expanded)]="popupExpanded" (click)="popupExpanded.set(true)" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{options().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
[cdkConnectedOverlayDisableClose]="true">
<ng-template ngComboboxPopup [combobox]="combobox">
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox example-popup" focusMode="activedescendant"
[tabindex]="-1" selectionMode="explicit" [(value)]="selectedOption" (click)="onCommit()"
(keydown.enter)="onCommit()" [activeDescendant]="listbox.activeDescendant()">
@for (option of options(); track option) {
<div class="example-option example-selectable example-stateful" ngOption [value]="option" [label]="option">
<span>{{option}}</span>
<span aria-hidden="true" class="material-symbols-outlined example-icon example-selected-icon">check</span>
</div>
<div class="example-popup">
@if (options().length === 0) {
<div class="example-no-results">No results found</div>
}
<div #listbox="ngListbox" ngListbox ngComboboxWidget class="example-listbox" focusMode="activedescendant"
[tabindex]="-1" selectionMode="explicit" [(value)]="selectedOption" (click)="onCommit()"
(keydown.enter)="onCommit()" [activeDescendant]="listbox.activeDescendant()"
[class.example-empty]="options().length === 0">
@for (option of options(); track option) {
<div class="example-option example-selectable example-stateful" ngOption [value]="option" [label]="option">
<span>{{option}}</span>
<span aria-hidden="true" class="material-symbols-outlined example-icon example-selected-icon">check</span>
</div>
}
</div>
</div>
</ng-template>
</ng-template>
Expand Down
22 changes: 16 additions & 6 deletions ...e-combobox/simple-combobox-tree-auto-select/simple-combobox-tree-auto-select-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,25 @@
[(value)]="searchString" [(expanded)]="popupExpanded" (click)="popupExpanded.set(true)" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{filteredGroups().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}"
[cdkConnectedOverlayOpen]="popupExpanded()" [cdkConnectedOverlayDisableClose]="true">
<ng-template ngComboboxPopup [combobox]="combobox" popupType="tree">
<ul ngTree ngComboboxWidget class="example-tree example-popup" focusMode="activedescendant" [tabindex]="-1"
selectionMode="follow" [(value)]="selectedValues" (click)="onCommit()" (keydown.enter)="onCommit()"
#tree="ngTree" [activeDescendant]="tree.activeDescendant()">
<ng-template [ngTemplateOutlet]="treeNodes"
[ngTemplateOutletContext]="{nodes: filteredGroups(), parent: tree}" />
</ul>
<div class="example-popup">
@if (filteredGroups().length === 0) {
<div class="example-no-results">No results found</div>
}
<ul ngTree ngComboboxWidget class="example-tree" focusMode="activedescendant" [tabindex="-1"
selectionMode="follow" [(value)]="selectedValues" (click)="onCommit()" (keydown.enter)="onCommit()"
#tree="ngTree" [activeDescendant]="tree.activeDescendant()"
[class.example-empty]="filteredGroups().length === 0">
<ng-template [ngTemplateOutlet]="treeNodes"
[ngTemplateOutletContext]="{nodes: filteredGroups(), parent: tree}" />
</ul>
</div>
</ng-template>
</ng-template>
</div>
Expand Down
22 changes: 16 additions & 6 deletions ...imple-combobox/simple-combobox-tree-highlight/simple-combobox-tree-highlight-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,25 @@
[inlineSuggestion]="(searchString() || navigated()) ? selectedValues()[0] : undefined" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{filteredGroups().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}" [cdkConnectedOverlayOpen]="true"
[cdkConnectedOverlayDisableClose]="true">
<ng-template ngComboboxPopup [combobox]="combobox" popupType="tree">
<ul ngTree ngComboboxWidget class="example-tree example-popup" focusMode="activedescendant" [tabindex]="-1"
selectionMode="follow" [(value)]="selectedValues" (click)="onCommit()" (keydown.enter)="onCommit()"
#tree="ngTree" [activeDescendant]="tree.activeDescendant()">
<ng-template [ngTemplateOutlet]="treeNodes"
[ngTemplateOutletContext]="{nodes: filteredGroups(), parent: tree}" />
</ul>
<div class="example-popup">
@if (filteredGroups().length === 0) {
<div class="example-no-results">No results found</div>
}
<ul ngTree ngComboboxWidget class="example-tree" focusMode="activedescendant" [tabindex]="-1"
selectionMode="follow" [(value)]="selectedValues" (click)="onCommit()" (keydown.enter)="onCommit()"
#tree="ngTree" [activeDescendant]="tree.activeDescendant()"
[class.example-empty]="filteredGroups().length === 0">
<ng-template [ngTemplateOutlet]="treeNodes"
[ngTemplateOutletContext]="{nodes: filteredGroups(), parent: tree}" />
</ul>
</div>
</ng-template>
</ng-template>
</div>
Expand Down
20 changes: 15 additions & 5 deletions ...ents-examples/aria/simple-combobox/simple-combobox-tree/simple-combobox-tree-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,24 @@
[(expanded)]="popupExpanded" (click)="popupExpanded.set(true)" />
</div>

<div aria-live="polite" class="cdk-visually-hidden">
{{filteredGroups().length === 0 ? 'No results found for ' + searchString() : ''}}
</div>

<ng-template [cdkConnectedOverlay]="{origin, usePopover: 'inline', matchWidth: true}"
[cdkConnectedOverlayOpen]="popupExpanded()" [cdkConnectedOverlayDisableClose]="true">
<ng-template ngComboboxPopup [combobox]="combobox" popupType="tree">
<ul ngTree ngComboboxWidget class="example-tree example-popup" focusMode="activedescendant" [tabindex]="-1"
selectionMode="explicit" [(value)]="selectedValues" (click)="onCommit()" (keydown.enter)="onCommit()" #tree="ngTree"
[activeDescendant]="tree.activeDescendant()">
<ng-template [ngTemplateOutlet]="treeNodes" [ngTemplateOutletContext]="{nodes: filteredGroups(), parent: tree}" />
</ul>
<div class="example-popup">
@if (filteredGroups().length === 0) {
<div class="example-no-results">No results found</div>
}
<ul ngTree ngComboboxWidget class="example-tree" focusMode="activedescendant" [tabindex]="-1"
selectionMode="explicit" [(value)]="selectedValues" (click)="onCommit()" (keydown.enter)="onCommit()" #tree="ngTree"
[activeDescendant]="tree.activeDescendant()"
[class.example-empty]="filteredGroups().length === 0">
<ng-template [ngTemplateOutlet]="treeNodes" [ngTemplateOutletContext]="{nodes: filteredGroups(), parent: tree}" />
</ul>
</div>
</ng-template>
</ng-template>
</div>
Expand Down
Loading