Skip to content

Commit 583cd52

Browse files
committed
build: mark rules_angular and rules_sass as dev dependencies
rules_angular and rules_sass are only needed for development and testing, and should not be propagated to downstream consumers.
1 parent 0844373 commit 583cd52

File tree

10 files changed

+17
-339
lines changed

10 files changed

+17
-339
lines changed

MODULE.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ local_path_override(
2727
path = "bazel/rules/rules_browsers",
2828
)
2929

30-
bazel_dep(name = "rules_sass")
30+
bazel_dep(name = "rules_sass", dev_dependency = True)
3131
local_path_override(
3232
module_name = "rules_sass",
3333
path = "bazel/rules/rules_sass",
3434
)
3535

36-
bazel_dep(name = "rules_angular")
36+
bazel_dep(name = "rules_angular", dev_dependency = True)
3737
local_path_override(
3838
module_name = "rules_angular",
3939
path = "bazel/rules/rules_angular",
@@ -65,7 +65,7 @@ node.toolchain(
6565
)
6666
use_repo(node, "nodejs_toolchains")
6767

68-
rules_angular = use_extension("@rules_angular//setup:extensions.bzl", "rules_angular")
68+
rules_angular = use_extension("@rules_angular//setup:extensions.bzl", "rules_angular", dev_dependency = True)
6969
rules_angular.setup(
7070
name = "dev_infra_rules_angular_configurable_deps",
7171
angular_compiler_cli = "//:node_modules/@angular/compiler-cli",

MODULE.bazel.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bazel/rules/rules_angular/MODULE.bazel

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@ local_path_override(
1616
path = "../rules_browsers",
1717
)
1818

19-
bazel_dep(name = "rules_sass", dev_dependency = True)
20-
local_path_override(
21-
module_name = "rules_sass",
22-
path = "../rules_sass",
23-
)
24-
2519
bazel_dep(name = "devinfra", dev_dependency = True)
2620
local_path_override(
2721
module_name = "devinfra",

bazel/rules/rules_angular/MODULE.bazel.lock

Lines changed: 1 addition & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bazel/rules/rules_browsers/MODULE.bazel

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,6 @@ bazel_dep(name = "platforms", version = "1.0.0")
3333
bazel_dep(name = "bazel_skylib", version = "1.9.0")
3434

3535
# Dev dependencies
36-
bazel_dep(name = "rules_angular", dev_dependency = True)
37-
local_path_override(
38-
module_name = "rules_angular",
39-
path = "../rules_angular",
40-
)
41-
42-
bazel_dep(name = "rules_sass", dev_dependency = True)
43-
local_path_override(
44-
module_name = "rules_sass",
45-
path = "../rules_sass",
46-
)
47-
4836
bazel_dep(name = "devinfra", dev_dependency = True)
4937
local_path_override(
5038
module_name = "devinfra",

bazel/rules/rules_browsers/MODULE.bazel.lock

Lines changed: 4 additions & 97 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bazel/rules/rules_browsers/test/MODULE.bazel

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,6 @@
33
module(name = "rules_browsers_test")
44

55
# Dev dependencies
6-
bazel_dep(name = "rules_angular", dev_dependency = True)
7-
local_path_override(
8-
module_name = "rules_angular",
9-
path = "../../rules_angular",
10-
)
11-
12-
bazel_dep(name = "rules_sass", dev_dependency = True)
13-
local_path_override(
14-
module_name = "rules_sass",
15-
path = "../../rules_sass",
16-
)
17-
186
bazel_dep(name = "devinfra", dev_dependency = True)
197
local_path_override(
208
module_name = "devinfra",

0 commit comments

Comments
 (0)