Skip to content

Commit 9584050

Browse files
committed
refactor: use native wtr.wtr_test rule
This now can be used as the issue was fixed upstream.
1 parent 84e350c commit 9584050

3 files changed

Lines changed: 2 additions & 19 deletions

File tree

bazel/rules/rules_browsers/wtr/BUILD.bazel

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,3 @@ js_library(
88
"wtr.config.mjs",
99
],
1010
)
11-
12-
exports_files(["wtr_runner.mjs"])

bazel/rules/rules_browsers/wtr/index.bzl

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@aspect_rules_js//js:defs.bzl", "js_test")
1+
load("@npm_rules_browsers//:@web/test-runner/package_json.bzl", wtr = "bin")
22

33
def _base_wtr_test(name, mode, deps, tags = [], **kwargs):
44
is_firefox = mode == "firefox"
@@ -31,13 +31,9 @@ def _base_wtr_test(name, mode, deps, tags = [], **kwargs):
3131
env = {"MANUAL_MODE": "1"}
3232
extra_tags += ["requires-network", "manual"]
3333

34-
# TODO(alanagius): Switch to `load("@npm_rules_browsers//:@web/test-runner/package_json.bzl", wtr = "bin")` once https://github.com/aspect-build/rules_js/commit/49201d1a4d362a3bf745b257fbf8d1f032e198c7#diff-b39b101d15f6349ce1a186d027b55e14d7e68f36604acf434d4e3f125f2c5519R86-R87 is fixed.
35-
js_test(
34+
wtr.wtr_test(
3635
name = name,
37-
entry_point = Label(":wtr_runner.mjs"),
38-
copy_data_to_bin = False,
3936
data = browser_deps + deps + [
40-
Label("//:node_modules/@web/test-runner"),
4137
Label("//:node_modules/@web/test-runner-core"),
4238
Label("//:node_modules/@web/test-runner-puppeteer"),
4339
Label("//:node_modules/get-port"),

bazel/rules/rules_browsers/wtr/wtr_runner.mjs

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)