Skip to content

fix(ng-dev): forcefully remove node_modules before publishing#3044

Closed
alan-agius4 wants to merge 1 commit into
angular:mainfrom
alan-agius4:log-clean
Closed

fix(ng-dev): forcefully remove node_modules before publishing#3044
alan-agius4 wants to merge 1 commit into
angular:mainfrom
alan-agius4:log-clean

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

Currently, when preparing a release, we execute 'git clean -dfq' to ensure a clean working directory. This is problematic when a '.gitignore' file is present that excludes 'node_modules', as 'git clean' will not remove them.

This change updates the release preparation to explicitly remove all 'node_modules' directories, ensuring that we always publish from a clean state.

Currently, when preparing a release, we execute 'git clean -dfq' to ensure a clean working directory. This is problematic when a '.gitignore' file is present that excludes 'node_modules', as 'git clean' will not remove them.

This change updates the release preparation to explicitly remove all 'node_modules' directories, ensuring that we always publish from a clean state.

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2025
@alan-agius4

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants