build: update bazel dependencies#3506
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This pull request updates several Bazel dependencies. The version bumps are appropriate. However, I've noticed that after updating jq.bzl, dangling entries for the old version remain in the lock files. I've left a specific comment on how to address this to ensure the lock files are clean and maintainable.
| bazel_dep(name = "aspect_rules_ts", version = "3.8.6") | ||
| bazel_dep(name = "bazel_skylib", version = "1.9.0") | ||
| bazel_dep(name = "jq.bzl", version = "0.4.0") | ||
| bazel_dep(name = "jq.bzl", version = "0.6.1") |
There was a problem hiding this comment.
While updating jq.bzl is correct, I've noticed that this change leaves dangling entries for the old version (0.4.0) in several MODULE.bazel.lock files across the repository. For example, in MODULE.bazel.lock and bazel/rules/rules_angular/MODULE.bazel.lock, the entry for jq.bzl/0.4.0/MODULE.bazel remains while the source.json entry is removed.
To ensure the lock files are clean and to prevent potential dependency resolution issues in the future, please remove these dangling entries. You might be able to fix this by running bazel mod tidy again, or by manually removing the leftover lines.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR contains the following updates:
0.25.0→0.25.13.0.2→3.0.33.8.5→3.8.61.8.2→1.9.00.4.0→0.6.1Release Notes
aspect-build/rules_ts (aspect_rules_ts)
v3.8.6Using Bzlmod:
Add to your
MODULE.bazelfile:Using legacy WORKSPACE
Paste this snippet into your
WORKSPACEfile:To use rules_ts with bazel-lib 2.x, you must additionally register the coreutils toolchain.
What's Changed
New Contributors
Full Changelog: aspect-build/rules_ts@v3.8.5...v3.8.6
bazelbuild/bazel-skylib (bazel_skylib)
v1.9.0Compare Source
What's Changed
copy_fileand setallow_symlinkby default toTrueifis_executableisFalse(#565)rules/private:is_windowsan emptyapplicable_license(#600)rules_godependency for compatibility with Bazel 9 (#601)Contributors:
@fdinoff, @fmeum, @fweikert, @susinmotion
Full Changelog: bazelbuild/bazel-skylib@1.8.2...1.9.0
bazel-contrib/jq.bzl (jq.bzl)
v0.6.1Using Bzlmod with Bazel 6 or greater
common --enable_bzlmodin.bazelrc.MODULE.bazelfile:Using WORKSPACE
Paste this snippet into your
WORKSPACE.bazelfile:What's Changed
New Contributors
Full Changelog: bazel-contrib/jq.bzl@v0.6.0...v0.6.1
v0.6.0Using Bzlmod with Bazel 6 or greater
common --enable_bzlmodin.bazelrc.MODULE.bazelfile:Using WORKSPACE
Paste this snippet into your
WORKSPACE.bazelfile:What's Changed
Full Changelog: bazel-contrib/jq.bzl@v0.5.1...v0.6.0
v0.5.1Using Bzlmod with Bazel 6 or greater
common --enable_bzlmodin.bazelrc.MODULE.bazelfile:Using WORKSPACE
Paste this snippet into your
WORKSPACE.bazelfile:What's Changed
New Contributors
Full Changelog: bazel-contrib/jq.bzl@v0.5.0...v0.5.1