Skip to content

refactor: use native wtr.wtr_test rule#3516

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:rules-browsers-wrt
Mar 12, 2026
Merged

refactor: use native wtr.wtr_test rule#3516
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:rules-browsers-wrt

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

This now can be used as the issue was fixed upstream.

This now can be used as the issue was fixed upstream.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the Web Test Runner setup to use the native wtr.wtr_test rule, which removes the need for a workaround script. The changes are clean, simplify the build configuration, and I have no further suggestions for improvement.

Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 merged commit f707ac5 into angular:main Mar 12, 2026
13 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the rules-browsers-wrt branch March 12, 2026 15:42
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants