build: refine module synchronization#3524
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates TypeScript to version 5.9.3 across the workspace and refines the sync-all-modules.sh script. The dependency updates appear correct and consistent with the goal of the PR. The script modification, which adds an update to the root lockfile within the synchronization loop, is a logical improvement for handling circular dependencies as described. I have one suggestion to enhance the robustness of the script.
Also refines the sync-all-modules.sh script to update the root lockfile during the synchronization pass. This ensures the root lockfile is accurate between module synchronization steps, which is necessary for pnpm ng-dev misc sync-module-bazel to function correctly when dealing with circular dependencies.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Also refines the sync-all-modules.sh script to update the root lockfile during the synchronization pass. This ensures the root lockfile is accurate between module synchronization steps, which is necessary for pnpm ng-dev misc sync-module-bazel to function correctly when dealing with circular dependencies.