ci: run renovate post-upgrade tasks only for npm and lockfile maintenance#3567
Conversation
…ance Update the Renovate configuration to only trigger post-upgrade commands (pnpm install, sync-all-modules.sh, and update-generated-files) when the npm manager is used or during lock-file maintenance. This ensures that Bazel manager updates not impacting the NPM lock-file or sync-module-bazel will not trigger those tasks.
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration to run post-upgrade tasks only for npm manager updates and lock file maintenance. The implementation correctly uses two separate rules to achieve the desired OR logic. However, this introduces duplication of the postUpgradeTasks block. While functionally correct, this could be improved for better maintainability by extracting the duplicated configuration into a shared preset. My review includes a suggestion on how to address this.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update the Renovate configuration to only trigger post-upgrade commands (pnpm install, sync-all-modules.sh, and update-generated-files) when the npm manager is used or during lock-file maintenance. This ensures that Bazel manager updates not impacting the NPM lock-file or sync-module-bazel will not trigger those tasks.