Skip to content

refactor(github-actions): update labeling prompt with descriptions#3580

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
thePunderWoman:labeler-desc
Apr 1, 2026
Merged

refactor(github-actions): update labeling prompt with descriptions#3580
alan-agius4 merged 1 commit into
angular:mainfrom
thePunderWoman:labeler-desc

Conversation

@thePunderWoman
Copy link
Copy Markdown
Contributor

This allows for providing more info via github label descriptions so the prompt can possibly do a better job of automatically labeling issues.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the issue labeling logic to include label descriptions in the AI prompt, transitioning the storage of area labels from a Set to a Map. Review feedback suggests refining the prompt string format to prevent potential AI parsing errors caused by unnecessary quotes and empty descriptions. Additionally, a discrepancy was identified in the test suite where the mock for the GitHub API method does not match the actual implementation, leading to tests passing accidentally.

Comment thread github-actions/labeling/issue/lib/issue-labeling.ts Outdated
Comment thread github-actions/labeling/issue/lib/issue-labeling.spec.ts
This allows for providing more info via github label descriptions so the prompt can possibly do a better job of automatically labeling issues.
@alan-agius4 alan-agius4 requested review from alan-agius4 and removed request for josephperrott March 31, 2026 19:16
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 1, 2026
@alan-agius4 alan-agius4 merged commit 616a50d into angular:main Apr 1, 2026
13 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants