Skip to content

build: update dependency which to v7#3656

Open
angular-robot wants to merge 1 commit intoangular:mainfrom
angular-robot:ng-renovate/which-7-x
Open

build: update dependency which to v7#3656
angular-robot wants to merge 1 commit intoangular:mainfrom
angular-robot:ng-renovate/which-7-x

Conversation

@angular-robot
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
which 6.0.17.0.0 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

npm/node-which (which)

v7.0.0

Compare Source

⚠️ BREAKING CHANGES
  • which now supports node ^22.22.2 || ^24.15.0 || >=26.0.0
  • template-oss-apply
Features
Chores

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels May 11, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the which dependency from version 6.0.1 to 7.0.0. A review comment identifies that which@7.0.0 introduces restrictive Node.js engine requirements that are incompatible with the project's current environment and other dependencies. It is recommended to revert to version 6.0.1 to maintain compatibility and prevent installation failures.

Comment thread ng-dev/package.json
"typescript": "6.0.3",
"utf-8-validate": "6.0.6",
"which": "6.0.1",
"which": "7.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The update to which@7.0.0 introduces significantly more restrictive Node.js engine requirements: ^22.22.2 || ^24.15.0 || >=26.0.0. This version drops support for Node.js 20 and earlier versions of Node.js 22 and 24.

Since other dependencies in this project (such as @angular-devkit/core) still support Node.js 20, and the project's own @types/node is at 24.12.2 (which is below the 24.15.0 minimum for the v24 range), this update will likely cause installation failures or runtime issues in many environments. It is recommended to revert to which@6 to maintain compatibility unless a project-wide Node.js version bump is intended.

Suggested change
"which": "7.0.0",
"which": "6.0.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant