Skip to content

build: update dependency which to v7 #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angular-robot wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

build: update dependency which to v7 #3656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ng-dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"tsx": "4.21.0",
"typescript": "6.0.3",
"utf-8-validate": "6.0.6",
"which": "6.0.1",
"which": "7.0.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The update to which@7.0.0 introduces significantly more restrictive Node.js engine requirements: ^22.22.2 || ^24.15.0 || >=26.0.0. This version drops support for Node.js 20 and earlier versions of Node.js 22 and 24.

Since other dependencies in this project (such as @angular-devkit/core) still support Node.js 20, and the project's own @types/node is at 24.12.2 (which is below the 24.15.0 minimum for the v24 range), this update will likely cause installation failures or runtime issues in many environments. It is recommended to revert to which@6 to maintain compatibility unless a project-wide Node.js version bump is intended.

Suggested change
"which": "7.0.0",
"which": "6.0.1",

"yaml": "2.8.4",
"yargs": "18.0.0",
"zod": "^4.3.6"
Expand Down
14 changes: 12 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading