Skip to content

Commit 6a699bf

Browse files
authored
Only allow the root module to override versions. (#32)
* Only allow the root module to override versions. This approach is taken from rules_rust. There's also a decent size discussion suggesting this: bazelbuild/bazel#22024. In either case, it seems reasonable that we don't go throught the whole module chain to resolve browser versions. Also removes the awakwark semver comparison. * fix formatting * Update MODULE.bazel ---------
1 parent 0e0949d commit 6a699bf

5 files changed

Lines changed: 153 additions & 99 deletions

File tree

MODULE.bazel

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ module(
55
version = "0.3.0",
66
)
77

8-
# Load browsers for tests.
8+
# Load default browser versions used by targets in `//browsers` for direct consumption. Test rules
9+
# provided from the module use these repositories transitively. The root module depending on
10+
# `rules_browsers` can override the version used in its `MODULE.bazel` file.
911
browsers = use_extension("//browsers:extensions.bzl", "browsers")
1012
browsers.chrome()
1113
browsers.chromedriver()
@@ -28,16 +30,16 @@ use_repo(
2830

2931
# Miscellaneous dependencies.
3032
bazel_dep(name = "platforms", version = "1.0.0")
31-
bazel_dep(name = "bazel_skylib", version = "1.8.1")
33+
bazel_dep(name = "bazel_skylib", version = "1.8.2")
3234

3335
# Manually specify a recent Node.js version.
34-
bazel_dep(name = "rules_nodejs", version = "6.5.0")
36+
bazel_dep(name = "rules_nodejs", version = "6.5.2")
3537

3638
node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
3739
node.toolchain(node_version = "22.18.0")
3840

3941
# JS
40-
bazel_dep(name = "aspect_rules_js", version = "2.4.2")
42+
bazel_dep(name = "aspect_rules_js", version = "2.6.2")
4143

4244
npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm")
4345
npm.npm_translate_lock(
@@ -53,7 +55,7 @@ npm.npm_translate_lock(
5355
use_repo(npm, "npm_rules_browsers")
5456

5557
# TS
56-
bazel_dep(name = "aspect_rules_ts", version = "3.6.3")
58+
bazel_dep(name = "aspect_rules_ts", version = "3.7.0")
5759

5860
rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext")
5961
rules_ts_ext.deps(

MODULE.bazel.lock

Lines changed: 47 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)