Skip to content

Commit 9bb4a12

Browse files
sbarfurthsbarfurth
committed
Enforce formatting with a presubmit
1 parent 713c7b6 commit 9bb4a12

6 files changed

Lines changed: 109 additions & 115 deletions

File tree

‎.github/workflows/presubmit.yaml‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name: Buildifier
2+
on:
3+
push:
4+
branches: [main]
5+
pull_request:
6+
branches: [main]
7+
# Allow manual execution.
8+
workflow_dispatch:
9+
jobs:
10+
buildifier:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@v4
14+
- uses: actions/setup-go@v5
15+
with:
16+
go-version: '1.24.0'
17+
- name: install
18+
run: go install github.com/bazelbuild/buildtools/buildifier@latest
19+
- name: check
20+
run: buildifier --mode=check -r .
21+
- name: lint
22+
run: buildifier --lint=warn -r .
23+
continue-on-error: true

‎MODULE.bazel‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ browsers = use_extension("//src/browsers:extensions.bzl", "browsers")
99
browsers.chrome()
1010
browsers.chromedriver()
1111
browsers.firefox()
12-
1312
use_repo(
1413
browsers,
1514
"rules_browsers_chrome_linux",
@@ -30,7 +29,6 @@ bazel_dep(name = "bazel_skylib", version = "1.8.1")
3029
bazel_dep(name = "aspect_rules_js", version = "2.4.2")
3130

3231
npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True)
33-
3432
npm.npm_translate_lock(
3533
name = "npm_rules_browsers",
3634
data = [
@@ -41,7 +39,6 @@ npm.npm_translate_lock(
4139
pnpm_lock = "//:pnpm-lock.yaml",
4240
verify_node_modules_ignored = "//:.bazelignore",
4341
)
44-
4542
use_repo(npm, "npm_rules_browsers")
4643

4744
pnpm = use_extension("@aspect_rules_js//npm:extensions.bzl", "pnpm")
@@ -54,9 +51,7 @@ use_repo(pnpm, "pnpm")
5451
bazel_dep(name = "aspect_rules_ts", version = "3.6.3")
5552

5653
rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext", dev_dependency = True)
57-
5854
rules_ts_ext.deps(
5955
ts_version_from = "//:package.json",
6056
)
61-
6257
use_repo(rules_ts_ext, "npm_typescript")

‎src/browsers/chromium/chromedriver.bzl‎

Lines changed: 28 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,32 @@
1-
21
load("//src/browsers/private:browser_repo.bzl", "browser_repo")
32

43
def define_chromedriver_repositories():
5-
6-
browser_repo(
7-
name = "rules_browsers_chromedriver_linux",
8-
sha256 = "0ef562acf7a87733a77cf51f52e3841cf7fb63c17d618b6ccb45a9a53ca89017",
9-
# 138.0.7204.49
10-
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/linux64/chromedriver-linux64.zip"],
11-
named_files = {"CHROMEDRIVER":"chromedriver-linux64/chromedriver"},
12-
exclude_patterns = [],
13-
exports_files = ["chromedriver-linux64/chromedriver"],
14-
)
15-
16-
17-
browser_repo(
18-
name = "rules_browsers_chromedriver_mac",
19-
sha256 = "bff1fc6075912698a1699a8d0979da3fdc576775a3fe78e6ae68338459c8882f",
20-
# 138.0.7204.49
21-
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-x64/chromedriver-mac-x64.zip"],
22-
named_files = {"CHROMEDRIVER":"chromedriver-mac-x64/chromedriver"},
23-
exclude_patterns = [],
24-
exports_files = ["chromedriver-mac-x64/chromedriver"],
25-
)
26-
27-
28-
browser_repo(
29-
name = "rules_browsers_chromedriver_mac_arm",
30-
sha256 = "dc64ab4843ea298f02cd69e2995b7441544d4132b74ac97e14a596eaaf1cd697",
31-
# 138.0.7204.49
32-
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-arm64/chromedriver-mac-arm64.zip"],
33-
named_files = {"CHROMEDRIVER":"chromedriver-mac-arm64/chromedriver"},
34-
exclude_patterns = [],
35-
exports_files = ["chromedriver-mac-arm64/chromedriver"],
36-
)
37-
4+
browser_repo(
5+
name = "rules_browsers_chromedriver_linux",
6+
sha256 = "0ef562acf7a87733a77cf51f52e3841cf7fb63c17d618b6ccb45a9a53ca89017",
7+
# 138.0.7204.49
8+
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/linux64/chromedriver-linux64.zip"],
9+
named_files = {"CHROMEDRIVER": "chromedriver-linux64/chromedriver"},
10+
exclude_patterns = [],
11+
exports_files = ["chromedriver-linux64/chromedriver"],
12+
)
13+
14+
browser_repo(
15+
name = "rules_browsers_chromedriver_mac",
16+
sha256 = "bff1fc6075912698a1699a8d0979da3fdc576775a3fe78e6ae68338459c8882f",
17+
# 138.0.7204.49
18+
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-x64/chromedriver-mac-x64.zip"],
19+
named_files = {"CHROMEDRIVER": "chromedriver-mac-x64/chromedriver"},
20+
exclude_patterns = [],
21+
exports_files = ["chromedriver-mac-x64/chromedriver"],
22+
)
3823

39-
40-
24+
browser_repo(
25+
name = "rules_browsers_chromedriver_mac_arm",
26+
sha256 = "dc64ab4843ea298f02cd69e2995b7441544d4132b74ac97e14a596eaaf1cd697",
27+
# 138.0.7204.49
28+
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-arm64/chromedriver-mac-arm64.zip"],
29+
named_files = {"CHROMEDRIVER": "chromedriver-mac-arm64/chromedriver"},
30+
exclude_patterns = [],
31+
exports_files = ["chromedriver-mac-arm64/chromedriver"],
32+
)

‎src/browsers/chromium/chromium.bzl‎

Lines changed: 28 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,32 @@
1-
21
load("//src/browsers/private:browser_repo.bzl", "browser_repo")
32

43
def define_chrome_repositories():
5-
6-
browser_repo(
7-
name = "rules_browsers_chrome_linux",
8-
sha256 = "142c7bce7a6f717c41c4c76f53a0db4f6ab72f2e0955eec7b2d8c9995c6c2668",
9-
# 138.0.7204.49
10-
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/linux64/chrome-headless-shell-linux64.zip"],
11-
named_files = {"CHROME-HEADLESS-SHELL":"chrome-headless-shell-linux64/chrome-headless-shell"},
12-
exclude_patterns = ["**/*.log"],
13-
exports_files = ["chrome-headless-shell-linux64/chrome-headless-shell"],
14-
)
15-
16-
17-
browser_repo(
18-
name = "rules_browsers_chrome_mac",
19-
sha256 = "5aa26c327efbfa6b88fb9beeb26701307dae99cbf77929a2bf241f4ddc97f8fc",
20-
# 138.0.7204.49
21-
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-x64/chrome-headless-shell-mac-x64.zip"],
22-
named_files = {"CHROME-HEADLESS-SHELL":"chrome-headless-shell-mac-x64/chrome-headless-shell"},
23-
exclude_patterns = ["**/*.log"],
24-
exports_files = ["chrome-headless-shell-mac-x64/chrome-headless-shell"],
25-
)
26-
27-
28-
browser_repo(
29-
name = "rules_browsers_chrome_mac_arm",
30-
sha256 = "e8759d758b2e709bbe241d7b6828d8f531a115010bd476d13a3912967ce72336",
31-
# 138.0.7204.49
32-
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-arm64/chrome-headless-shell-mac-arm64.zip"],
33-
named_files = {"CHROME-HEADLESS-SHELL":"chrome-headless-shell-mac-arm64/chrome-headless-shell"},
34-
exclude_patterns = ["**/*.log"],
35-
exports_files = ["chrome-headless-shell-mac-arm64/chrome-headless-shell"],
36-
)
37-
4+
browser_repo(
5+
name = "rules_browsers_chrome_linux",
6+
sha256 = "142c7bce7a6f717c41c4c76f53a0db4f6ab72f2e0955eec7b2d8c9995c6c2668",
7+
# 138.0.7204.49
8+
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/linux64/chrome-headless-shell-linux64.zip"],
9+
named_files = {"CHROME-HEADLESS-SHELL": "chrome-headless-shell-linux64/chrome-headless-shell"},
10+
exclude_patterns = ["**/*.log"],
11+
exports_files = ["chrome-headless-shell-linux64/chrome-headless-shell"],
12+
)
13+
14+
browser_repo(
15+
name = "rules_browsers_chrome_mac",
16+
sha256 = "5aa26c327efbfa6b88fb9beeb26701307dae99cbf77929a2bf241f4ddc97f8fc",
17+
# 138.0.7204.49
18+
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-x64/chrome-headless-shell-mac-x64.zip"],
19+
named_files = {"CHROME-HEADLESS-SHELL": "chrome-headless-shell-mac-x64/chrome-headless-shell"},
20+
exclude_patterns = ["**/*.log"],
21+
exports_files = ["chrome-headless-shell-mac-x64/chrome-headless-shell"],
22+
)
3823

39-
40-
24+
browser_repo(
25+
name = "rules_browsers_chrome_mac_arm",
26+
sha256 = "e8759d758b2e709bbe241d7b6828d8f531a115010bd476d13a3912967ce72336",
27+
# 138.0.7204.49
28+
urls = ["https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.49/mac-arm64/chrome-headless-shell-mac-arm64.zip"],
29+
named_files = {"CHROME-HEADLESS-SHELL": "chrome-headless-shell-mac-arm64/chrome-headless-shell"},
30+
exclude_patterns = ["**/*.log"],
31+
exports_files = ["chrome-headless-shell-mac-arm64/chrome-headless-shell"],
32+
)

‎src/browsers/firefox/firefox.bzl‎

Lines changed: 28 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,32 @@
1-
21
load("@rules_browsers//src/browsers/private:browser_repo.bzl", "browser_repo")
32

43
def define_firefox_repositories():
5-
6-
browser_repo(
7-
name = "rules_browsers_firefox_linux",
8-
sha256 = "6fcc1a2f95a6b232af82b4b7644566638c5df349e3095c65b7c18d1a63412d3d",
9-
# stable_135.0
10-
urls = ["https://archive.mozilla.org/pub/firefox/releases/135.0/linux-x86_64/en-US/firefox-135.0.tar.xz"],
11-
named_files = {"FIREFOX":"firefox/firefox"},
12-
exclude_patterns = [],
13-
exports_files = ["firefox/firefox"],
14-
)
15-
16-
17-
browser_repo(
18-
name = "rules_browsers_firefox_mac",
19-
sha256 = "e55e24e6b2a4980f4b9091900835977b282f599dcdd5e38b753d95bad8a11da9",
20-
# stable_135.0
21-
urls = ["https://archive.mozilla.org/pub/firefox/releases/135.0/mac/en-US/Firefox%20135.0.dmg"],
22-
named_files = {"FIREFOX":"Firefox.app/Contents/MacOS/firefox"},
23-
exclude_patterns = [],
24-
exports_files = ["Firefox.app/Contents/MacOS/firefox"],
25-
)
26-
27-
28-
browser_repo(
29-
name = "rules_browsers_firefox_mac_arm",
30-
sha256 = "e55e24e6b2a4980f4b9091900835977b282f599dcdd5e38b753d95bad8a11da9",
31-
# stable_135.0
32-
urls = ["https://archive.mozilla.org/pub/firefox/releases/135.0/mac/en-US/Firefox%20135.0.dmg"],
33-
named_files = {"FIREFOX":"Firefox.app/Contents/MacOS/firefox"},
34-
exclude_patterns = [],
35-
exports_files = ["Firefox.app/Contents/MacOS/firefox"],
36-
)
37-
4+
browser_repo(
5+
name = "rules_browsers_firefox_linux",
6+
sha256 = "6fcc1a2f95a6b232af82b4b7644566638c5df349e3095c65b7c18d1a63412d3d",
7+
# stable_135.0
8+
urls = ["https://archive.mozilla.org/pub/firefox/releases/135.0/linux-x86_64/en-US/firefox-135.0.tar.xz"],
9+
named_files = {"FIREFOX": "firefox/firefox"},
10+
exclude_patterns = [],
11+
exports_files = ["firefox/firefox"],
12+
)
13+
14+
browser_repo(
15+
name = "rules_browsers_firefox_mac",
16+
sha256 = "e55e24e6b2a4980f4b9091900835977b282f599dcdd5e38b753d95bad8a11da9",
17+
# stable_135.0
18+
urls = ["https://archive.mozilla.org/pub/firefox/releases/135.0/mac/en-US/Firefox%20135.0.dmg"],
19+
named_files = {"FIREFOX": "Firefox.app/Contents/MacOS/firefox"},
20+
exclude_patterns = [],
21+
exports_files = ["Firefox.app/Contents/MacOS/firefox"],
22+
)
3823

39-
40-
24+
browser_repo(
25+
name = "rules_browsers_firefox_mac_arm",
26+
sha256 = "e55e24e6b2a4980f4b9091900835977b282f599dcdd5e38b753d95bad8a11da9",
27+
# stable_135.0
28+
urls = ["https://archive.mozilla.org/pub/firefox/releases/135.0/mac/en-US/Firefox%20135.0.dmg"],
29+
named_files = {"FIREFOX": "Firefox.app/Contents/MacOS/firefox"},
30+
exclude_patterns = [],
31+
exports_files = ["Firefox.app/Contents/MacOS/firefox"],
32+
)

‎src/wtr/index.bzl‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,13 @@ def wtr_test(name, deps, firefox = True, chromium = True, **kwargs):
6363
if chromium:
6464
_base_wtr_test("%s_chromium" % name, deps = deps, mode = "chromium", **kwargs)
6565
tests.append(":%s_chromium" % name)
66-
66+
6767
_base_wtr_test("%s_debug" % name, deps = deps, mode = "manual", **kwargs)
6868

6969
if len(tests) == 0:
7070
fail("A least one of `chromium` or `firefox` must be enabled")
7171

7272
native.test_suite(
7373
name = name,
74-
tests = tests
74+
tests = tests,
7575
)

0 commit comments

Comments
 (0)