fix: ignore truncated Gemini responses#67
Merged
crisbeto merged 1 commit intoangular:mainfrom Sep 30, 2025
Merged
Conversation
Occasionally Gemini truncates the response on the `class=` sequence. These changes ignore such responses to reduce noise from the results.
devversion
reviewed
Sep 30, 2025
| // Consider these cases as invalid so they don't influence the results. | ||
| return ( | ||
| files.length === 0 || | ||
| !files.some((file) => file.code.trim().endsWith('class=')) |
Member
There was a problem hiding this comment.
This makes sense to treat as "invalid", but two questions:
- Wouldn't such output result in a failed build etc anyway?
- This seems Angular specific? how can other frameworks configure this?
Member
Author
There was a problem hiding this comment.
- If there's an API error, we ignore the full run further down so these won't show up at all.
- It's basically a no-op for other frameworks so I figured that we don't really need to configure it.
Member
There was a problem hiding this comment.
I see, for (2) I was thinking other frameworks might see same issues and want to "error out gracefully" then. We can always follow up on this
devversion
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally Gemini truncates the response on the
class=sequence. These changes ignore such responses to reduce noise from the results.