refactor: do not repair a11y failures by default#69
Merged
crisbeto merged 1 commit intoangular:mainfrom Sep 30, 2025
Merged
Conversation
We will stop repairing a11y failures by default because agents by default don't do this and it would therefore give a more realistic insight into app quality. The main motivator triggering this change is that we occasionally see that a11y repairs re-introduce actual build failures. Those cases are captured as they can be useful insight, but it would rather confuse results in the default mode. Hence the change. The a11y repair attempts can be configured via an opt-in CLI flag.
crisbeto
approved these changes
Sep 30, 2025
Member
Author
|
cc. @tjshiu do we want to chat more about this? We thought this is a necessary change to address the issue, while still supporting insight into how a11y repairs could help/ or regress build success |
devversion
added a commit
to devversion/web-codegen-scorer
that referenced
this pull request
Nov 12, 2025
We accidentally regressed when we introduced the test command feature. See the rationale we had back then (shortly before we landed the test command feature): angular#69
devversion
added a commit
that referenced
this pull request
Nov 12, 2025
We accidentally regressed when we introduced the test command feature. See the rationale we had back then (shortly before we landed the test command feature): #69
devversion
added a commit
to devversion/web-codegen-scorer
that referenced
this pull request
Nov 12, 2025
See context: angular#69. We just accidentally increased back to `1` during the refactoring.
devversion
added a commit
that referenced
this pull request
Nov 12, 2025
See context: #69. We just accidentally increased back to `1` during the refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will stop repairing a11y failures by default because agents by default don't do this and it would therefore give a more realistic insight into app quality.
The main motivator triggering this change is that we occasionally see that a11y repairs re-introduce actual build failures. Those cases are captured as they can be useful insight, but it would rather confuse results in the default mode. Hence the change.
The a11y repair attempts can be configured via an opt-in CLI flag.
Also makes it easier to spot the attempt success/failures: