Commit 8a9d731
Revert IQuantity.UnitInfo DIM in favor of GetUnitInfo() extension on all TFMs
Reverts the default interface members added in #1649 and instead exposes
GetUnitInfo() / GetUnitInfo<TUnit>() as extension methods on all target
frameworks (previously gated behind #if !NET).
Rationale (per @lipchev review feedback on #1649):
- DIM bloats the IQuantity contract with members that just delegate to
QuantityInfo[UnitKey]; aim is a leaner interface.
- A custom IQuantity implementor overriding UnitInfo would silently
diverge from internal lookups (UnitConverter, UnitAbbreviationsCache
etc.) which always go through QuantityInfo, not the new property.
- Calling the DIM through the IQuantity interface on a struct quantity
causes interface dispatch and boxing per call.
The extension method has none of these issues and gives the same
ergonomic call-site (quantity.GetUnitInfo()) on every TFM.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 2a60bf9 commit 8a9d731
3 files changed
Lines changed: 8 additions & 34 deletions
File tree
- UnitsNet.Tests/CustomCode
- UnitsNet
- Extensions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | 19 | | |
25 | 20 | | |
26 | 21 | | |
| |||
32 | 27 | | |
33 | 28 | | |
34 | 29 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 30 | | |
40 | 31 | | |
41 | 32 | | |
42 | 33 | | |
43 | 34 | | |
44 | | - | |
45 | 35 | | |
46 | 36 | | |
47 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | 61 | | |
73 | 62 | | |
74 | 63 | | |
| |||
105 | 94 | | |
106 | 95 | | |
107 | 96 | | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | 97 | | |
112 | 98 | | |
113 | | - | |
114 | | - | |
115 | 99 | | |
116 | 100 | | |
117 | 101 | | |
| |||
0 commit comments