UnitParser: adding overloads for getting a UnitInfo using a type/name and abbreviation#1585
Merged
angularsen merged 2 commits intoJul 27, 2025
Conversation
… and abbreviation
Collaborator
Author
|
I'm currently using the getters in the UnitInfo unitInfo;
if (quantityName != null && unitAbbreviation != null)
{
unitInfo = _unitParser.GetUnitFromAbbreviation(quantityName, unitAbbreviation, serializer.Culture);
}
else if (unitAbbreviation != null)
{
unitInfo = objectType == typeof(IQuantity)
? _unitParser.GetUnitFromAbbreviation(unitAbbreviation, serializer.Culture)
: _unitParser.GetUnitFromAbbreviation(Nullable.GetUnderlyingType(objectType) ?? objectType, unitAbbreviation, serializer.Culture);
}
else if (quantityName != null)
{
unitInfo = _unitParser.Quantities.GetQuantityByName(quantityName).BaseUnitInfo;
}
else if (objectType != typeof(IQuantity))
{
unitInfo = _unitParser.Quantities.GetQuantityInfo(Nullable.GetUnderlyingType(objectType) ?? objectType).BaseUnitInfo;
}
else
{
throw new FormatException("The target unit cannot be determined from the provided JSON.");
}Technically, if we wanted to- we could make add the serialization project as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the following (public) methods to the
UnitParserUnitInfo GetUnitFromAbbreviation(string quantityName, string unitAbbreviation, IFormatProvider? formatProvider)UnitInfo GetUnitFromAbbreviation(Type quantityType, string unitAbbreviation, IFormatProvider? formatProvider)bool TryGetUnitFromAbbreviation(string quantityName, string? unitAbbreviation, IFormatProvider? formatProvider, [NotNullWhen(true)] out UnitInfo? unitInfo)bool TryGetUnitFromAbbreviation(Type quantityType, string? unitAbbreviation, IFormatProvider? formatProvider, [NotNullWhen(true)] out UnitInfo? unitInfo)