Skip to content

Making the methods from UnitMath that exist in System.Linq as [Obsolete]#1593

Merged
angularsen merged 1 commit into
angularsen:maintenance/v5from
lipchev:obsolete-methods-unitmath
Aug 9, 2025
Merged

Making the methods from UnitMath that exist in System.Linq as [Obsolete]#1593
angularsen merged 1 commit into
angularsen:maintenance/v5from
lipchev:obsolete-methods-unitmath

Conversation

@lipchev
Copy link
Copy Markdown
Collaborator

@lipchev lipchev commented Aug 3, 2025

Making the Min / Max of an IEnumerable and their selector overloads [Obsolete] in v5 (to be removed in v6).

@lipchev
Copy link
Copy Markdown
Collaborator Author

lipchev commented Aug 3, 2025

@angularsen Note that the extensions in System.Linq aren't directly applicable to a collection of IQuantity as it doesn't implement the IComparable interface (and even if it did- the result of sorting a mix of different quantities wouldn't be obvious).

If you agree that we don't want them any more, I can simply remove these in #1587 and we'll have less to talk about next time..

@angularsen
Copy link
Copy Markdown
Owner

Yes, let's remove Min/Max extension methods on the untyped IQuantity. It doesn't make sense to compare Mass and Length.

@angularsen angularsen merged commit 72a4dd1 into angularsen:maintenance/v5 Aug 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants