Making the QuantityInfoLookup public#1597
Merged
angularsen merged 4 commits intoAug 9, 2025
Merged
Conversation
- exposing the Quantities associated with a given UnitParser and UnitAbbreviationsCache
Collaborator
Author
|
@angularsen I don't see any reason to hold this one internal, but other than the utility functions it provides to the user, there isn't any particular requirement for it to be public. |
lipchev
commented
Aug 3, 2025
Comment on lines
-91
to
-94
| /// <remarks> | ||
| /// Access type is <c>internal</c> until this class is matured and ready for external use. | ||
| /// </remarks> | ||
| internal QuantityInfoLookup QuantityInfoLookup { get; } |
Collaborator
Author
There was a problem hiding this comment.
I haven't got any burning need to rename this, but it would perhaps make it more consistent if we used Quantities as the property name.
Owner
There was a problem hiding this comment.
Yes to consistency please, I renamed it
angularsen
approved these changes
Aug 9, 2025
Comment on lines
-91
to
-94
| /// <remarks> | ||
| /// Access type is <c>internal</c> until this class is matured and ready for external use. | ||
| /// </remarks> | ||
| internal QuantityInfoLookup QuantityInfoLookup { get; } |
Owner
There was a problem hiding this comment.
Yes to consistency please, I renamed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuantityInfoLookuptype publicQuantitiesassociated with a givenUnitParserandUnitAbbreviationsCacheQuantityInfoLookupproperty of theUnitsNetSetup