Skip to content

✨Add Duration.Picoseconds #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angularsen merged 2 commits into from
Jul 26, 2025
Merged

✨Add Duration.Picoseconds #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e7e60
adding pico seconds unit.
benito-dataart Jun 25, 2025
f731eec
Merge remote-tracking branch 'origin/master' into feature/adding-pico…
angularsen Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Common/UnitDefinitions/Duration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
},
"FromUnitToBaseFunc": "{x}",
"FromBaseToUnitFunc": "{x}",
"Prefixes": [ "Nano", "Micro", "Milli" ],
"Prefixes": [ "Pico", "Nano", "Micro", "Milli" ],
"Localization": [
{
"Culture": "en-US",
Expand Down
3 changes: 2 additions & 1 deletion Common/UnitEnumValues.g.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@
"Second": 9,
"Week": 10,
"Year365": 11,
"Sol": 15
"Sol": 15,
"Picosecond": 12
},
"DynamicViscosity": {
"Centipoise": 1,
Expand Down
12 changes: 12 additions & 0 deletions UnitsNet.NanoFramework/GeneratedCode/Quantities/Duration.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions UnitsNet.NanoFramework/GeneratedCode/Units/DurationUnit.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions UnitsNet.NumberExtensions.Tests/GeneratedCode/NumberToDurationExtensionsTest.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions UnitsNet.NumberExtensions/GeneratedCode/NumberToDurationExtensions.g.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 27 additions & 8 deletions UnitsNet.Tests/CustomCode/DurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,16 @@ public class DurationTests : DurationTestsBase
protected override double JulianYearsInOneSecond => 3.16880878140289e-08;

protected override double SolsInOneSecond => 1.126440159375963e-5;


protected override double PicosecondsInOneSecond => 1e+12;

[Fact]
public void AllBaseQuantityUnitsAreBaseUnits()
{
Assert.All(Duration.Info.UnitInfos, unitInfo => Assert.Equal(new BaseUnits(time: unitInfo.Value), unitInfo.BaseUnits));
Assert.All(
Duration.Info.UnitInfos,
unitInfo => Assert.Equal(new BaseUnits(time: unitInfo.Value), unitInfo.BaseUnits)
);
}

[Fact]
Expand Down Expand Up @@ -73,7 +78,10 @@ public static void ToTimeSpanShouldNotThrowExceptionOnValuesSlightlySmallerThanT
[InlineData(100, Units.DurationUnit.Nanosecond)]
[InlineData(1, Units.DurationUnit.Microsecond)]
[InlineData(1.234, Units.DurationUnit.Millisecond)]
public static void ToTimeSpanShouldNotRoundToMillisecond(double value, Units.DurationUnit unit)
public static void ToTimeSpanShouldNotRoundToMillisecond(
double value,
Units.DurationUnit unit
)
{
Duration duration = Duration.From(value, unit);
TimeSpan timeSpan = duration.ToTimeSpan();
Expand Down Expand Up @@ -196,11 +204,22 @@ public void DurationTimesVolumeFlowEqualsVolume()
[InlineData("1 сек", 1, "ru-RU")]
[InlineData("1000 мс", 1, "ru-RU")]
[InlineData("1000 мсек", 1, "ru-RU")]
public void DurationFromStringUsingMultipleAbbreviationsParsedCorrectly(string textValue, double expectedSeconds, string? culture = null)
{
var cultureInfo = culture == null ? CultureInfo.InvariantCulture : CultureInfo.GetCultureInfo(culture);

AssertEx.EqualTolerance(expectedSeconds, Duration.Parse(textValue, cultureInfo).Seconds, SecondsTolerance);
public void DurationFromStringUsingMultipleAbbreviationsParsedCorrectly(
string textValue,
double expectedSeconds,
string? culture = null
)
{
var cultureInfo =
culture == null
? CultureInfo.InvariantCulture
: CultureInfo.GetCultureInfo(culture);

AssertEx.EqualTolerance(
expectedSeconds,
Duration.Parse(textValue, cultureInfo).Seconds,
SecondsTolerance
);
}

[Fact]
Expand Down
Loading