Skip to content

[BUG] crash in background, foreground service while app already closed #1462 #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MianMuzammil67 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG] crash in background, foreground service while app already closed #1462 #1500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion .../player/src/main/java/dev/anilbeesetti/nextplayer/feature/player/service/PlayerService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
package dev.anilbeesetti.nextplayer.feature.player.service

import android.app.NotificationChannel
import android.app.NotificationManager
import android.app.PendingIntent
import android.content.ContentResolver
import android.content.Intent
import android.net.Uri
import android.os.Build
import android.os.Bundle
import androidx.annotation.OptIn
import androidx.core.app.NotificationCompat
import androidx.core.net.toUri
import androidx.media3.common.AudioAttributes
import androidx.media3.common.C
Expand Down Expand Up @@ -72,6 +75,9 @@ import kotlinx.coroutines.launch
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.supervisorScope

private const val PLAYER_NOTIFICATION_CHANNEL_ID = "player_channel"
private const val PLAYER_NOTIFICATION_ID = 1

@OptIn(UnstableApi::class)
@AndroidEntryPoint
class PlayerService : MediaSessionService() {
Expand Down Expand Up @@ -416,6 +422,28 @@ class PlayerService : MediaSessionService() {

override fun onCreate() {
super.onCreate()

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
val channel = NotificationChannel(
PLAYER_NOTIFICATION_CHANNEL_ID,
"Next Player",
NotificationManager.IMPORTANCE_LOW,
).apply {
description = "Media playback notifications"
}
(getSystemService(NOTIFICATION_SERVICE) as NotificationManager)
.createNotificationChannel(channel)
}

val notification = NotificationCompat.Builder(this, PLAYER_NOTIFICATION_CHANNEL_ID)
.setContentTitle("Next Player")
.setContentText("Playing media")
.setSmallIcon(R.drawable.artwork_default)
.setOngoing(true)
.build()

startForeground(PLAYER_NOTIFICATION_ID, notification)

val renderersFactory = NextRenderersFactory(applicationContext)
.setEnableDecoderFallback(true)
.setExtensionRendererMode(
Expand Down