Update RustSynth to version 0.5.1 with various improvements and optimizations

- Enhanced frame processing in `lib.rs` for better performance by modifying pixel access patterns.
- Bumped version numbers in `Cargo.toml` files for `rustsynth`, `rustsynth-derive`, and `rustsynth-sys` to 0.5.1.
- Removed unused `FilterType` enum from `traits.rs` to clean up the codebase.
- Improved error handling and safety in `frame.rs` by using raw pointer access for property retrieval and setting.
- Added constants for property keys in `frame.rs` to avoid magic strings and improve readability.
- Refactored property access methods to use unsafe raw access for performance gains.

Author: animafps

Cargo.lock

@@ -63,18 +63,19 @@ mod plugin {
 
             // Actually do the invert operation
             for plane in 0..vf.num_planes {
-                let srcp = src.get_read_ptr(plane);
-                let dstp = dst.get_write_ptr(plane);
+                let mut srcp = src.get_read_ptr(plane);
+                let mut dstp = dst.get_write_ptr(plane);
                 let stride = src.get_stride(plane) as usize;
                 let h = src.get_height(plane) as usize;
                 let w = src.get_width(plane) as usize;
 
-                for y in 0..h {
-                    for x in 0..w {
-                        unsafe {
-                            let src_pixel = *srcp.add(y * stride + x);
-                            *dstp.add(y * stride + x) = !src_pixel;
+                unsafe {
+                    for _y in 0..h {
+                        for x in 0..w {
+                            *dstp.add(x) = !(*srcp.add(x));
                         }
+                        srcp = srcp.add(stride);
+                        dstp = dstp.add(stride);
                     }
                 }
             }

example/src/lib.rs

@@ -1,7 +1,7 @@
 [package]
 name = "rustsynth-derive"
 description = "Procedual macro helpers for rustsynth"
-version = "0.5.0"
+version = "0.5.1"
 edition = "2021"
 license = "LGPL-2.1"
 authors = ["Anima <contact@animafps.xyz>"]
@@ -16,4 +16,4 @@ proc-macro = true
 syn = { version = "2.0", features = ["full"] }
 quote = "1.0"
 proc-macro2 = "1.0"
-rustsynth = { version = "=0.5.0", path = "../rustsynth" }
+rustsynth = { version = "=0.5.1", path = "../rustsynth" }

rustsynth-derive/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "rustsynth-sys"
 description = "Low level bindings to VapourSynth"
-version = "0.5.0"
+version = "0.5.1"
 edition = "2021"
 license = "LGPL-2.1"
 authors = ["Anima <contact@animafps.xyz>"]

rustsynth-sys/Cargo.toml

@@ -29,4 +29,4 @@ macro_rules! version {
 pub const VAPOURSYNTH_API_VERSION: i32 =
     version!(VAPOURSYNTH_API_MAJOR as i32, VAPOURSYNTH_API_MINOR as i32);
 pub const VSSCRIPT_API_VERSION: i32 =
-    version!(VSSCRIPT_API_MAJOR as i32, VSSCRIPT_API_MINOR as i32);
+    version!(VSSCRIPT_API_MAJOR as i32, VSSCRIPT_API_MINOR as i32);

rustsynth-sys/src/lib.rs

@@ -1,6 +1,6 @@
 [package]
 name = "rustsynth"
-version = "0.5.0"
+version = "0.5.1"
 edition = "2021"
 license = "LGPL-2.1"
 description = "Safe VapourSynth wrapper"
@@ -10,11 +10,11 @@ categories = ["multimedia::video", "api-bindings"]
 keywords = ["vapoursynth"]
 
 [dependencies]
-rustsynth-sys = { version = "=0.5.0", path = "../rustsynth-sys" }
+rustsynth-sys = { version = "=0.5.1", path = "../rustsynth-sys" }
 thiserror = "1.0"
 bitflags = "1.3"
 half = { version = "2.0", optional = true }
-futures = "0.3.31"
+futures = "0.3"
 
 [features]
 # Enable the half::f16 type to be used for frame pixel data.

rustsynth/Cargo.toml

@@ -2,7 +2,6 @@ use rustsynth_sys::{VSActivationReason, VSFilterMode};
 
 use crate::ffi;
 use crate::ffi::VSRequestPattern;
-use crate::frame::{Frame, FrameContext};
 use crate::node::Node;
 
 pub struct FilterDependency {
@@ -96,34 +95,6 @@ impl FilterMode {
     }
 }
 
-/// A filter’s “getframe” function. It is called by the core when it needs the filter to generate a frame.
-/// It is possible to allocate local data, persistent during the multiple calls requesting the output frame.
-/// In case of error, call setFilterError and return [None].
-/// Depending on the [FilterMode] set for the filter, multiple output frames could be requested concurrently.
-/// It is never called concurrently for the same frame number.
-///
-/// # Arguments
-///
-/// * `n`: Requested frame number.
-/// * `activation_reason`: This function is first called with [ActivationReason::Initial]. At this point the function should request the input frames it needs and return [None]. When one or all of the requested frames are ready, this function is called again with [ActivationReason::AllFramesReady]. The function should only return a frame when called with [ActivationReason::AllFramesReady].
-/// If a the function is called with [ActivationReason::Error] all processing has to be aborted and any.
-/// * `instance_data`: The filter’s private instance data.
-/// * `frame_data`:     Optional private data associated with output frame number `n``. It must be deallocated before the last call for the given frame ([ActivationReason::AllFramesReady] or error).
-pub type FilterGetFrame<'a> = fn(
-    n: i32,
-    activation_reason: ActivationReason,
-    instance_data: &mut [u8],
-    frame_data: &mut Option<&mut [u8; 4]>,
-    frame_ctx: &FrameContext,
-) -> Option<Frame<'a>>;
-
-// Free callback signature
-pub type FilterFree = fn(instance_data: &mut [u8]);
-
-// TODO!
-// - Filter Traits
-// - Export macros
-
 pub mod traits;
 
 // Macro to automatically register filters

rustsynth/src/filter/mod.rs

@@ -7,11 +7,6 @@ use crate::{
     map::Map,
 };
 
-pub enum FilterType {
-    Video,
-    Audio,
-}
-
 /// Trait that filter structs must implement
 pub trait Filter {
     const NAME: &'static str;

rustsynth/src/filter/traits.rs

@@ -145,12 +145,10 @@ impl VideoFormat {
     pub(crate) fn from_ptr(from: *const ffi::VSVideoFormat) -> Self {
         let info = unsafe { &*from };
 
-        let sample_type = if info.sampleType == 0 {
+        let sample_type = if info.sampleType == ffi::VSSampleType::stInteger as i32 {
             SampleType::Integer
-        } else if info.sampleType == 1 {
-            SampleType::Float
         } else {
-            panic!("Sample type not valid")
+            SampleType::Float
         };
 
         let color_family = match info.colorFamily {
@@ -218,11 +216,10 @@ impl AudioFormat {
         let from = &*from;
         let sample_type = if from.sampleType == 0 {
             SampleType::Integer
-        } else if from.sampleType == 1 {
-            SampleType::Float
         } else {
-            panic!("Sample type not valid")
+            SampleType::Float
         };
+
         Self {
             sample_type,
             bits_per_sample: from.bitsPerSample,