Skip to content

chore: Prefer async functions #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mroderick wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: Prefer async functions #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions test/RateLimiterRedis.redis.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,18 @@ describe('RateLimiterRedis with fixed window', function RateLimiterRedisTest() {
await redisMockClient.quit();
})

it('consume 1 point', (done) => {
it('consumes 1 point', async () => {
const testKey = 'consume1';
const rateLimiter = new RateLimiterRedis({
storeClient: redisMockClient,
points: 2,
duration: 5,
});
rateLimiter
.consume(testKey)
.then(() => {
redisMockClient.get(rateLimiter.getKey(testKey)).then((consumedPoints)=>{
expect(consumedPoints).to.equal('1');
done();
});
})
.catch((err) => {
done(err);
});
await rateLimiter.consume(testKey);

const consumedPoints = await redisMockClient.get(rateLimiter.getKey(testKey));

expect(consumedPoints).to.equal('1');
});

it('rejected when consume more than maximum points', (done) => {
Expand Down