#113 fix queue delay with exec evenly flag#359
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an execEvenly interaction where the resolved RateLimiterRes.msBeforeNext could be “stale” (still including the time already waited due to execEvenly delay), which could cause downstream logic like RateLimiterQueue to over-wait.
Changes:
- Adjust
RateLimiterRes.msBeforeNextby subtracting the appliedexecEvenlydelay before resolving. - Add coverage to ensure
msBeforeNextis updated afterexecEvenly-based waiting. - Add a queue-level regression test to ensure no extra wait occurs when the underlying limiter uses
execEvenly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/RateLimiterQueue.test.js | Adds regression test for queue timing when underlying limiter uses execEvenly. |
| test/RateLimiterMemory.test.js | Adds test asserting msBeforeNext is reduced after an execEvenly delay. |
| lib/RateLimiterStoreAbstract.js | Updates exec-evenly resolve path to reduce msBeforeNext by the actual delay waited. |
| lib/RateLimiterMemory.js | Mirrors the same msBeforeNext adjustment for the in-memory limiter’s exec-evenly path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.