Dark mode clean#1
Open
aniro wants to merge 2 commits into
Open
Conversation
Implements dark mode for the UI, editors, and language syntax highlighting via a QDarkStyle stylesheet and Lua-variable-driven color theming. Dark mode can be toggled in Preferences and takes effect after a restart. Bug fixes applied on top of the original PR: - Replace non-existent Settings.h with ApplicationSettings.h; drop Settings* alias. - Fix EditorManager::setupEditorTheme() calling getSettings() from wrong class; use the settings member directly. - Fix typo darModeChanged -> darkModeChanged (was a compile error). - Add styleClearAll() after STYLE_DEFAULT fore/back in setupEditorTheme() so colors propagate to all styles; fixes white-background regression in debug builds. - Restore setCharsDefault() and setWordChars() dropped from setupEditor(). - Guard setCaretFore(DARK_DEFAULT_FG) behind darkMode check in LuaConsoleDock. - Move STYLE_DEFAULT fore/back before styleClearAll() in LuaConsoleDock::setupStyle(). - Fix missing parens in invertColor and rgb2bgr macros (operator-precedence safety).
ScintillaTypes.h and Geometry.h use intptr_t/uintptr_t without including <cstdint>, causing compile errors with recent GCC versions. PlatQt.h has the same issue transitively. Add the missing include to each file. Update the Qt Advanced Docking System submodule to tag 4.2.0, which is the version that ads.pri references (AutoHideDockContainer and related files were added in 4.2.0 and are absent in the previously checked-out commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.