This repository was archived by the owner on May 5, 2020. It is now read-only.
Fixes issue #1132. Implemented ConstraintLayout#1360
Open
devanshi7799 wants to merge 1 commit into
Open
Conversation
Author
|
Please review this and tell me what more changes are to be made |
Contributor
|
@devanshi7799 how is this solving the nesting issue? I think you need to flatten the Layout hierarchy. And it needs to be done for 3 XML files, I can see changes made only to one |
|
@sammy1997 sir can i work on this issue? |
Contributor
|
@therealsanjeev The issue has been assigned to @devanshi7799 so she is working on it currently |
ok sir |
Author
|
@sammy1997 working on it. |
Contributor
|
@devanshi7799 there are 9 commits and many of them are not passing the build. Please squash the commits into 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented ConstraintLayout in gamemap.xml file. Changed FrameLayout to ConstraintLayout
Fixes #1132
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Tested it on my android phone
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only