Fixes issue #697. Text is now visible properly in vocab match game#1390
Fixes issue #697. Text is now visible properly in vocab match game#1390devanshi7799 wants to merge 1 commit into
Conversation
| android:gravity="center"/> | ||
| android:gravity="center" | ||
| android:paddingLeft="@dimen/vocam_match_padding" | ||
| /> |
There was a problem hiding this comment.
Write line no 83 in the following way: android:paddingLeft="@dimen/vocam_match_padding" />
Always try to avoid the use of extra lines.
pknotfound
left a comment
There was a problem hiding this comment.
@devanshi7799
Is there a typo in this?
I think it should be @dimen/vocab_match_padding instead of @dimen/vocam_match_padding?
What do you think?
|
@Priyansh-Kedia Oh , I might have misspelled it. Thanks for pointing it out :) |
Happy to help |
|
@devanshi7799 Please squash the commits. I can see 5 commits in the PR |
|
@sammy i will make the necessary changes and upadate the PR soon :)) |
|
@sammy1997 I have squashed the commits. Can you please review it? |
|
I can still see that the text is coming out of the pad. Wrapping the text or auto-resizing would be a better way to solve this. Can you try that @devanshi7799 ? |
|
@sammy1997 Yes sure! I Will solve it and get back to you |
Description
I have made changes in the activity_vocab_match_game.xml file. I have simply added padding value to keep the text at the centre of the image
Fixes #697
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
I have tested this on two android devices(vivo y51l and micromax HS2) and it works perfectly fine
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only