fix(supabase): revert owner-mismatch DO blocks in smtp_senders and whatsapp_sessions (#2840)

The DO blocks with EXCEPTION WHEN insufficient_privilege added in #2838
and #2839 let the migration runner skip CREATE INDEX, ENABLE RLS, and
CREATE POLICY when the table was owned by a different role. That made
the deploy pass while the real application code would still hit
permission denied at runtime, which is a worse failure mode than a
failing deploy.

Restore the IF NOT EXISTS / DROP IF EXISTS idempotency patterns from
#2836. The migration now fails loudly when ownership is misaligned so
the issue must be fixed out-of-band (drop and recreate the table, or
ALTER TABLE ... OWNER TO) before the migration can succeed.

Author: malek10xdev

supabase/migrations/20260530120000_add_smtp_senders.sql

@@ -18,26 +18,12 @@ CREATE TABLE IF NOT EXISTS private.smtp_senders (
    UNIQUE(user_id, email)
  );
 
--- CREATE INDEX / CREATE POLICY / ENABLE RLS on an existing table require
--- ownership. On QA the table may have been pre-applied by a role that
--- doesn't match the migration runner, so these no-op cleanly when we lack
--- privilege. Whoever pre-applied the table is responsible for the
--- index / RLS / policy.
-DO $$
-BEGIN
-  CREATE INDEX idx_smtp_senders_user_id ON private.smtp_senders(user_id);
-EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL;
-END $$;
+CREATE INDEX IF NOT EXISTS idx_smtp_senders_user_id ON private.smtp_senders(user_id);
 
-DO $$
-BEGIN
-  EXECUTE 'ALTER TABLE private.smtp_senders ENABLE ROW LEVEL SECURITY';
-EXCEPTION WHEN insufficient_privilege THEN NULL;
-END $$;
+ALTER TABLE private.smtp_senders ENABLE ROW LEVEL SECURITY;
 
-DO $$
-BEGIN
-  EXECUTE 'DROP POLICY IF EXISTS "Users can manage own smtp_senders" ON private.smtp_senders';
-  EXECUTE 'CREATE POLICY "Users can manage own smtp_senders" ON private.smtp_senders USING (auth.uid() = user_id) WITH CHECK (auth.uid() = user_id)';
-EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL;
-END $$;
+DROP POLICY IF EXISTS "Users can manage own smtp_senders" ON private.smtp_senders;
+CREATE POLICY "Users can manage own smtp_senders"
+  ON private.smtp_senders
+  USING (auth.uid() = user_id)
+  WITH CHECK (auth.uid() = user_id);

supabase/migrations/20260601000000_add_whatsapp_gateway.sql

@@ -32,21 +32,33 @@ CREATE TABLE IF NOT EXISTS private.whatsapp_sessions (
 );
 
 -- Indexes
--- CREATE INDEX / CREATE POLICY on an existing table require ownership.
--- On QA the table may have been pre-applied by a role that doesn't match
--- the migration runner, so these no-op cleanly when we lack privilege.
-DO $$ BEGIN CREATE INDEX idx_whatsapp_sessions_user_id ON private.whatsapp_sessions(user_id); EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL; END $$;
-DO $$ BEGIN CREATE INDEX idx_whatsapp_sessions_status ON private.whatsapp_sessions(status); EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL; END $$;
-DO $$ BEGIN CREATE INDEX idx_whatsapp_sessions_active ON private.whatsapp_sessions(is_active); EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL; END $$;
+CREATE INDEX IF NOT EXISTS idx_whatsapp_sessions_user_id ON private.whatsapp_sessions(user_id);
+CREATE INDEX IF NOT EXISTS idx_whatsapp_sessions_status ON private.whatsapp_sessions(status);
+CREATE INDEX IF NOT EXISTS idx_whatsapp_sessions_active ON private.whatsapp_sessions(is_active);
 
 -- Enable RLS
-DO $$ BEGIN EXECUTE 'ALTER TABLE private.whatsapp_sessions ENABLE ROW LEVEL SECURITY'; EXCEPTION WHEN insufficient_privilege THEN NULL; END $$;
+ALTER TABLE private.whatsapp_sessions ENABLE ROW LEVEL SECURITY;
 
 -- RLS Policies for whatsapp_sessions
-DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can view own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can view own whatsapp sessions" ON private.whatsapp_sessions FOR SELECT USING (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
-DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can insert own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can insert own whatsapp sessions" ON private.whatsapp_sessions FOR INSERT WITH CHECK (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
-DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can update own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can update own whatsapp sessions" ON private.whatsapp_sessions FOR UPDATE USING (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
-DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can delete own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can delete own whatsapp sessions" ON private.whatsapp_sessions FOR DELETE USING (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
+DROP POLICY IF EXISTS "Users can view own whatsapp sessions" ON private.whatsapp_sessions;
+CREATE POLICY "Users can view own whatsapp sessions"
+  ON private.whatsapp_sessions FOR SELECT
+  USING (auth.uid() = user_id);
+
+DROP POLICY IF EXISTS "Users can insert own whatsapp sessions" ON private.whatsapp_sessions;
+CREATE POLICY "Users can insert own whatsapp sessions"
+  ON private.whatsapp_sessions FOR INSERT
+  WITH CHECK (auth.uid() = user_id);
+
+DROP POLICY IF EXISTS "Users can update own whatsapp sessions" ON private.whatsapp_sessions;
+CREATE POLICY "Users can update own whatsapp sessions"
+  ON private.whatsapp_sessions FOR UPDATE
+  USING (auth.uid() = user_id);
+
+DROP POLICY IF EXISTS "Users can delete own whatsapp sessions" ON private.whatsapp_sessions;
+CREATE POLICY "Users can delete own whatsapp sessions"
+  ON private.whatsapp_sessions FOR DELETE
+  USING (auth.uid() = user_id);
 
 -- Trigger to automatically update updated_at
 CREATE OR REPLACE FUNCTION private.update_whatsapp_session_updated_at()