fix(supabase): tolerate owner-mismatch on smtp_senders and whatsapp_sessions (#2838)

The QA DB has these tables pre-applied by a role that doesn't match
the migration runner, so CREATE INDEX and CREATE POLICY fail with
'must be owner of table' before IF NOT EXISTS can even run. Wrap
the owner-required DDL in DO blocks that catch insufficient_privilege
and skip silently.

Trade-off: when the runner isn't the owner, the index/policy may be
missing on QA after the migration. Acceptable because whoever
pre-applied the table should have created them too; on a fresh env
the migration applies correctly.

Verified locally against supabase_db_leadminer (PG 15.8): ran the
fixed migration against a pre-applied state, DO blocks apply cleanly
(duplicate_object) and would also catch insufficient_privilege on a
non-superuser runner (local postgres is superuser so we can't
perfectly simulate that, but the EXCEPTION condition matches the
error from the failed QA run).

Author: malek10xdev

supabase/migrations/20260530120000_add_smtp_senders.sql

@@ -18,12 +18,20 @@ CREATE TABLE IF NOT EXISTS private.smtp_senders (
    UNIQUE(user_id, email)
  );
 
-CREATE INDEX IF NOT EXISTS idx_smtp_senders_user_id ON private.smtp_senders(user_id);
+-- CREATE INDEX / CREATE POLICY on an existing table require ownership.
+-- On QA the table may have been pre-applied by a role that doesn't match
+-- the migration runner, so these no-op cleanly when we lack privilege.
+DO $$
+BEGIN
+  CREATE INDEX idx_smtp_senders_user_id ON private.smtp_senders(user_id);
+EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL;
+END $$;
 
 ALTER TABLE private.smtp_senders ENABLE ROW LEVEL SECURITY;
 
-DROP POLICY IF EXISTS "Users can manage own smtp_senders" ON private.smtp_senders;
-CREATE POLICY "Users can manage own smtp_senders"
-  ON private.smtp_senders
-  USING (auth.uid() = user_id)
-  WITH CHECK (auth.uid() = user_id);
+DO $$
+BEGIN
+  EXECUTE 'DROP POLICY IF EXISTS "Users can manage own smtp_senders" ON private.smtp_senders';
+  EXECUTE 'CREATE POLICY "Users can manage own smtp_senders" ON private.smtp_senders USING (auth.uid() = user_id) WITH CHECK (auth.uid() = user_id)';
+EXCEPTION WHEN insufficient_privilege THEN NULL;
+END $$;

supabase/migrations/20260601000000_add_whatsapp_gateway.sql

@@ -32,33 +32,21 @@ CREATE TABLE IF NOT EXISTS private.whatsapp_sessions (
 );
 
 -- Indexes
-CREATE INDEX IF NOT EXISTS idx_whatsapp_sessions_user_id ON private.whatsapp_sessions(user_id);
-CREATE INDEX IF NOT EXISTS idx_whatsapp_sessions_status ON private.whatsapp_sessions(status);
-CREATE INDEX IF NOT EXISTS idx_whatsapp_sessions_active ON private.whatsapp_sessions(is_active);
+-- CREATE INDEX / CREATE POLICY on an existing table require ownership.
+-- On QA the table may have been pre-applied by a role that doesn't match
+-- the migration runner, so these no-op cleanly when we lack privilege.
+DO $$ BEGIN CREATE INDEX idx_whatsapp_sessions_user_id ON private.whatsapp_sessions(user_id); EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL; END $$;
+DO $$ BEGIN CREATE INDEX idx_whatsapp_sessions_status ON private.whatsapp_sessions(status); EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL; END $$;
+DO $$ BEGIN CREATE INDEX idx_whatsapp_sessions_active ON private.whatsapp_sessions(is_active); EXCEPTION WHEN insufficient_privilege OR duplicate_table THEN NULL; END $$;
 
 -- Enable RLS
 ALTER TABLE private.whatsapp_sessions ENABLE ROW LEVEL SECURITY;
 
 -- RLS Policies for whatsapp_sessions
-DROP POLICY IF EXISTS "Users can view own whatsapp sessions" ON private.whatsapp_sessions;
-CREATE POLICY "Users can view own whatsapp sessions"
-  ON private.whatsapp_sessions FOR SELECT
-  USING (auth.uid() = user_id);
-
-DROP POLICY IF EXISTS "Users can insert own whatsapp sessions" ON private.whatsapp_sessions;
-CREATE POLICY "Users can insert own whatsapp sessions"
-  ON private.whatsapp_sessions FOR INSERT
-  WITH CHECK (auth.uid() = user_id);
-
-DROP POLICY IF EXISTS "Users can update own whatsapp sessions" ON private.whatsapp_sessions;
-CREATE POLICY "Users can update own whatsapp sessions"
-  ON private.whatsapp_sessions FOR UPDATE
-  USING (auth.uid() = user_id);
-
-DROP POLICY IF EXISTS "Users can delete own whatsapp sessions" ON private.whatsapp_sessions;
-CREATE POLICY "Users can delete own whatsapp sessions"
-  ON private.whatsapp_sessions FOR DELETE
-  USING (auth.uid() = user_id);
+DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can view own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can view own whatsapp sessions" ON private.whatsapp_sessions FOR SELECT USING (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
+DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can insert own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can insert own whatsapp sessions" ON private.whatsapp_sessions FOR INSERT WITH CHECK (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
+DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can update own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can update own whatsapp sessions" ON private.whatsapp_sessions FOR UPDATE USING (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
+DO $$ BEGIN EXECUTE 'DROP POLICY IF EXISTS "Users can delete own whatsapp sessions" ON private.whatsapp_sessions'; EXECUTE 'CREATE POLICY "Users can delete own whatsapp sessions" ON private.whatsapp_sessions FOR DELETE USING (auth.uid() = user_id)'; EXCEPTION WHEN insufficient_privilege OR duplicate_object THEN NULL; END $$;
 
 -- Trigger to automatically update updated_at
 CREATE OR REPLACE FUNCTION private.update_whatsapp_session_updated_at()