Skip to content

Commit cbabc61

Browse files
committed
fix: allow campaign processor to work without fallback sender when using mining sources (OAuth)
- Remove blocking requirement for fallback sender at processor start - Fallback sender is now optional - processor will use mining sources per campaign - Keep fallback sender check for email-sending-request notification endpoint
1 parent da8ea49 commit cbabc61

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

  • supabase/functions/email-campaigns

supabase/functions/email-campaigns/index.ts

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,26 +1796,26 @@ app.post(
17961796
async (c: Context) => {
17971797
const supabaseAdmin = createSupabaseAdmin();
17981798
let fallbackSenderEmail = "";
1799-
if (!isFallbackSenderEnabled()) {
1800-
return c.json(
1801-
{
1802-
error: "Fallback sender is disabled",
1803-
code: "FALLBACK_SENDER_DISABLED",
1804-
},
1805-
500,
1806-
);
1807-
}
1808-
try {
1809-
fallbackSenderEmail = requireFallbackSenderEmail();
1810-
} catch (error) {
1811-
return c.json(
1812-
{
1813-
error: extractErrorMessage(error),
1814-
code: "SMTP_SENDER_NOT_CONFIGURED",
1815-
},
1816-
500,
1799+
1800+
// Allow processing without fallback sender if campaigns use mining sources (OAuth)
1801+
if (isFallbackSenderEnabled()) {
1802+
try {
1803+
fallbackSenderEmail = requireFallbackSenderEmail();
1804+
} catch (error) {
1805+
logger.warn(
1806+
"Fallback sender not configured, will use mining sources per campaign",
1807+
{
1808+
error: extractErrorMessage(error),
1809+
},
1810+
);
1811+
fallbackSenderEmail = "";
1812+
}
1813+
} else {
1814+
logger.info(
1815+
"Fallback sender disabled, will use mining sources per campaign",
18171816
);
18181817
}
1818+
18191819
const dayStart = getTodayUtcStartString();
18201820
const processingDeadline = Date.now() + PROCESSING_DEADLINE_MS;
18211821
logger.debug("Starting campaign processing", {

0 commit comments

Comments
 (0)