Started update to Rice 4.8

Author: ankane

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.16.2 (unreleased)
+
+- Fixed error with Rice 4.8
+
 ## 0.16.1 (2025-10-26)
 
 - Added `add_allowed_assignments` and `add_forbidden_assignments` methods to `CpModel`

ext/or-tools/bin_packing.cpp

@@ -24,7 +24,7 @@ namespace Rice::detail {
 
     explicit From_Ruby(Arg* arg) : arg_(arg) { }
 
-    Convertible is_convertible(VALUE value) { return Convertible::Cast; }
+    double is_convertible(VALUE value) { return Convertible::Exact; }
 
     KnapsackSolver::SolverType convert(VALUE x) {
       auto s = Symbol(x).str();

ext/or-tools/constraint.cpp

@@ -44,7 +44,7 @@ namespace Rice::detail {
 
     explicit From_Ruby(Arg* arg) : arg_(arg) { }
 
-    Convertible is_convertible(VALUE value) { return Convertible::Cast; }
+    double is_convertible(VALUE value) { return Convertible::Exact; }
 
     LinearExpr convert(VALUE v) {
       LinearExpr expr;

ext/or-tools/linear.cpp

@@ -30,7 +30,7 @@ namespace Rice::detail {
 
     explicit From_Ruby(Arg* arg) : arg_(arg) { }
 
-    Convertible is_convertible(VALUE value) { return Convertible::Cast; }
+    double is_convertible(VALUE value) { return Convertible::Exact; }
 
     static MPSolver::OptimizationProblemType convert(VALUE x) {
       auto s = Symbol(x).str();

ext/or-tools/math_opt.cpp

@@ -29,7 +29,7 @@ namespace Rice::detail {
 
     explicit From_Ruby(Arg* arg) : arg_(arg) { }
 
-    Convertible is_convertible(VALUE value) { return Convertible::Cast; }
+    double is_convertible(VALUE value) { return Convertible::Exact; }
 
     static SolverType convert(VALUE x) {
       auto s = Symbol(x).str();

ext/or-tools/routing.cpp

@@ -40,7 +40,7 @@ namespace Rice::detail {
 
     explicit From_Ruby(Arg* arg) : arg_(arg) { }
 
-    Convertible is_convertible(VALUE value) { return Convertible::Cast; }
+    double is_convertible(VALUE value) { return Convertible::Exact; }
 
     RoutingNodeIndex convert(VALUE x) {
       const RoutingNodeIndex index{From_Ruby<int>().convert(x)};
@@ -65,6 +65,35 @@ namespace Rice::detail {
   private:
     Arg* arg_ = nullptr;
   };
+
+  template<>
+  struct Type<RoutingModel::PenaltyCostBehavior> {
+    static bool verify() { return true; }
+  };
+
+  template<>
+  class From_Ruby<RoutingModel::PenaltyCostBehavior> {
+  public:
+    From_Ruby() = default;
+
+    explicit From_Ruby(Arg* arg) : arg_(arg) { }
+
+    double is_convertible(VALUE value) { return Convertible::Exact; }
+
+    RoutingModel::PenaltyCostBehavior convert(VALUE x) {
+      auto s = Symbol(x).str();
+      if (s == "penalize_once") {
+        return RoutingModel::PenaltyCostBehavior::PENALIZE_ONCE;
+      } else if (s == "penalize_per_inactive") {
+        return RoutingModel::PenaltyCostBehavior::PENALIZE_PER_INACTIVE;
+      } else {
+        throw std::runtime_error("Unknown penalty cost behavior: " + s);
+      }
+    }
+
+  private:
+    Arg* arg_ = nullptr;
+  };
 } // namespace Rice::detail
 
 void init_routing(Rice::Module& m) {

or-tools.gemspec

@@ -16,5 +16,5 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 3.1"
 
-  spec.add_dependency "rice", ">= 4.7"
+  spec.add_dependency "rice", ">= 4.8"
 end

test/constraint_test.rb

@@ -232,7 +232,7 @@ def test_add_hint
     error = assert_raises(RuntimeError) do
       model.add_hint("z", 1)
     end
-    assert_equal "The provided Ruby object does not wrap a C++ object", error.message
+    assert_equal "The Ruby object does not wrap a C++ object. It is actually a String.", error.message
   end
 
   def test_int_var_domain