refactor(common): extract CrashReportService interface to :common

Create CrashReporter interface and CrashReportService delegate object
in :common (package com.ichi2.anki) so all modules can report crashes
without depending on the app module. Move runCatchingWithReport to
:common.

Rename the ACRA-backed implementation to AcraCrashReporter (internal)
in :AnkiDroid. Wire up via CrashReportService.setReporter() in
AnkiDroidApp.onCreate().

Existing call sites keep using CrashReportService.sendExceptionReport
with the same package — no import changes needed for ~40 files.
Only 7 files using ACRA-specific methods updated to AcraCrashReporter.

Author: criticalAY

AnkiDroid/src/androidTest/java/com/ichi2/anki/tests/ACRATest.kt

@@ -23,13 +23,18 @@ import androidx.test.annotation.UiThreadTest
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.ichi2.anki.AnkiDroidApp
 import com.ichi2.anki.CrashReportService
-import com.ichi2.anki.CrashReportService.FEEDBACK_REPORT_ALWAYS
-import com.ichi2.anki.CrashReportService.FEEDBACK_REPORT_ASK
+import com.ichi2.anki.CrashReporter.Companion.FEEDBACK_REPORT_ALWAYS
+import com.ichi2.anki.CrashReporter.Companion.FEEDBACK_REPORT_ASK
+import com.ichi2.anki.CrashReporter.Companion.FEEDBACK_REPORT_KEY
+import com.ichi2.anki.CrashReporter.Companion.FEEDBACK_REPORT_NEVER
 import com.ichi2.anki.R
 import com.ichi2.anki.analytics.UsageAnalytics
+import com.ichi2.anki.getAcraCoreConfigBuilder
 import com.ichi2.anki.logging.ProductionCrashReportingTree
 import com.ichi2.anki.preferences.sharedPrefs
 import com.ichi2.anki.servicelayer.ThrowableFilterService
+import com.ichi2.anki.setDebugACRAConfig
+import com.ichi2.anki.setProductionACRAConfig
 import com.ichi2.anki.testutil.GrantStoragePermission
 import org.acra.ACRA
 import org.acra.builder.ReportBuilder
@@ -70,10 +75,10 @@ class ACRATest : InstrumentedTest() {
     @Throws(Exception::class)
     fun testDebugConfiguration() {
         // Debug mode overrides all saved state so no setup needed
-        CrashReportService.setDebugACRAConfig(sharedPrefs)
+        setDebugACRAConfig(sharedPrefs)
         assertArrayEquals(
             "Debug logcat arguments not set correctly",
-            CrashReportService.acraCoreConfigBuilder
+            getAcraCoreConfigBuilder()
                 .build()
                 .logcatArguments
                 .toTypedArray(),
@@ -90,21 +95,21 @@ class ACRATest : InstrumentedTest() {
         )
         assertEquals(
             "ACRA feedback was not turned off correctly",
-            CrashReportService.FEEDBACK_REPORT_NEVER,
+            FEEDBACK_REPORT_NEVER,
             sharedPrefs
-                .getString(CrashReportService.FEEDBACK_REPORT_KEY, "undefined"),
+                .getString(FEEDBACK_REPORT_KEY, "undefined"),
         )
     }
 
     @Test
     @Throws(Exception::class)
     fun testProductionConfigurationUserDisabled() {
         // set up as if the user had prefs saved to disable completely
-        setReportConfig(CrashReportService.FEEDBACK_REPORT_NEVER)
+        setReportConfig(FEEDBACK_REPORT_NEVER)
 
         // ACRA initializes production logcat via annotation and we can't mock Build.DEBUG
         // That means we are restricted from verifying production logcat args and this is the debug case again
-        CrashReportService.setProductionACRAConfig(sharedPrefs)
+        setProductionACRAConfig(sharedPrefs)
         verifyDebugACRAPreferences()
     }
 
@@ -115,7 +120,7 @@ class ACRATest : InstrumentedTest() {
         setReportConfig(FEEDBACK_REPORT_ASK)
 
         // If the user is set to ask, then it's production, with interaction mode dialog
-        CrashReportService.setProductionACRAConfig(sharedPrefs)
+        setProductionACRAConfig(sharedPrefs)
         verifyACRANotDisabled()
 
         assertToastMessage(R.string.feedback_for_manual_toast_text)
@@ -134,7 +139,7 @@ class ACRATest : InstrumentedTest() {
 
         // If the user is set to always, then it's production, with interaction mode toast
         // will be useful with ACRA 5.2.0
-        CrashReportService.setProductionACRAConfig(sharedPrefs)
+        setProductionACRAConfig(sharedPrefs)
 
         // The same class/method combo is only sent once, so we face a new method each time (should test that system later)
         val crash = Exception("testCrashReportSend at " + System.currentTimeMillis())
@@ -153,12 +158,12 @@ class ACRATest : InstrumentedTest() {
         val crashData =
             CrashReportDataFactory(
                 testContext,
-                CrashReportService.acraCoreConfigBuilder.build(),
+                getAcraCoreConfigBuilder().build(),
             ).createCrashData(ReportBuilder().exception(crash))
         assertTrue(
             LimitingReportAdministrator().shouldSendReport(
                 testContext,
-                CrashReportService.acraCoreConfigBuilder.build(),
+                getAcraCoreConfigBuilder().build(),
                 crashData,
             ),
         )
@@ -167,19 +172,19 @@ class ACRATest : InstrumentedTest() {
         assertFalse(
             LimitingReportAdministrator().shouldSendReport(
                 testContext,
-                CrashReportService.acraCoreConfigBuilder.build(),
+                getAcraCoreConfigBuilder().build(),
                 crashData,
             ),
         )
 
         // Now let's clear data
-        CrashReportService.deleteACRALimiterData(testContext)
+        CrashReportService.deleteLimiterData(testContext)
 
         // A third send should work again
         assertTrue(
             LimitingReportAdministrator().shouldSendReport(
                 testContext,
-                CrashReportService.acraCoreConfigBuilder.build(),
+                getAcraCoreConfigBuilder().build(),
                 crashData,
             ),
         )
@@ -192,7 +197,7 @@ class ACRATest : InstrumentedTest() {
         setReportConfig(FEEDBACK_REPORT_ALWAYS)
 
         // If the user is set to always, then it's production, with interaction mode toast
-        CrashReportService.setProductionACRAConfig(sharedPrefs)
+        setProductionACRAConfig(sharedPrefs)
         verifyACRANotDisabled()
 
         assertToastMessage(R.string.feedback_auto_toast_text)
@@ -207,13 +212,13 @@ class ACRATest : InstrumentedTest() {
         setReportConfig(FEEDBACK_REPORT_ALWAYS)
 
         // If the user is set to ask, then it's production, with interaction mode dialog
-        CrashReportService.setProductionACRAConfig(sharedPrefs)
+        setProductionACRAConfig(sharedPrefs)
         verifyACRANotDisabled()
 
         assertDialogEnabledStatus("dialog should be disabled when status is ALWAYS", false)
         assertToastMessage(R.string.feedback_auto_toast_text)
 
-        setAcraReportingMode(FEEDBACK_REPORT_ASK)
+        CrashReportService.setReportingMode(FEEDBACK_REPORT_ASK)
 
         assertDialogEnabledStatus("dialog should be re-enabled after changed to ASK", true)
         assertToastMessage(R.string.feedback_for_manual_toast_text)
@@ -226,12 +231,12 @@ class ACRATest : InstrumentedTest() {
         setReportConfig(FEEDBACK_REPORT_ASK)
 
         // If the user is set to ask, then it's production, with interaction mode dialog
-        CrashReportService.setProductionACRAConfig(sharedPrefs)
+        setProductionACRAConfig(sharedPrefs)
         verifyACRANotDisabled()
 
         assertToastMessage(R.string.feedback_for_manual_toast_text)
 
-        setAcraReportingMode(FEEDBACK_REPORT_ALWAYS)
+        CrashReportService.setReportingMode(FEEDBACK_REPORT_ALWAYS)
 
         assertToastMessage(R.string.feedback_auto_toast_text)
     }
@@ -281,16 +286,12 @@ class ACRATest : InstrumentedTest() {
         )
     }
 
-    private fun setAcraReportingMode(feedbackReportAlways: String) {
-        CrashReportService.setAcraReportingMode(feedbackReportAlways)
-    }
-
     @Throws(ACRAConfigurationException::class)
     private fun assertDialogEnabledStatus(
         message: String,
         isEnabled: Boolean,
     ) {
-        val config = CrashReportService.acraCoreConfigBuilder.build()
+        val config = getAcraCoreConfigBuilder().build()
         for (configuration in config.pluginConfigurations) {
             // Make sure the dialog is set to pop up
             if (configuration.javaClass.toString().contains("Dialog")) {
@@ -301,7 +302,7 @@ class ACRATest : InstrumentedTest() {
 
     @Throws(ACRAConfigurationException::class)
     private fun assertToastIsEnabled() {
-        val config = CrashReportService.acraCoreConfigBuilder.build()
+        val config = getAcraCoreConfigBuilder().build()
         for (configuration in config.pluginConfigurations) {
             if (configuration.javaClass.toString().contains("Toast")) {
                 assertThat("Toast should be enabled", configuration.enabled(), equalTo(true))
@@ -313,7 +314,7 @@ class ACRATest : InstrumentedTest() {
     private fun assertToastMessage(
         @StringRes res: Int,
     ) {
-        val config = CrashReportService.acraCoreConfigBuilder.build()
+        val config = getAcraCoreConfigBuilder().build()
         for (configuration in config.pluginConfigurations) {
             if (configuration.javaClass.toString().contains("Toast")) {
                 assertEquals(
@@ -333,7 +334,7 @@ class ACRATest : InstrumentedTest() {
     }
 
     private fun setReportConfig(feedbackReportAsk: String) {
-        sharedPrefs.edit { putString(CrashReportService.FEEDBACK_REPORT_KEY, feedbackReportAsk) }
+        sharedPrefs.edit { putString(FEEDBACK_REPORT_KEY, feedbackReportAsk) }
     }
 
     private val sharedPrefs: SharedPreferences