Skip to content

Commit 296f773

Browse files
Haz3-joltmikehardy
authored andcommitted
fix(changeNoteType): hide headers and warning for cloze conversions
When converting to/from a cloze note type, the template tab incorrectly showed "Current"/"New" column headers and a discarded-cards warning. Now, when templates cannot be changed (any cloze conversion), the header layout and removal warning are hidden alongside the spinners. Also removes a duplicate visibility assignment line. Fixes: #20873 Assisted-by: Claude Opus 4.7 - discussion & rubber duck Signed-off-by: Hari Srinivasan <harisrini21@gmail.com>
1 parent 182e799 commit 296f773

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ChangeNoteTypeDialog.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,13 +488,18 @@ class ChangeNoteTypeDialog : AnalyticsDialogFragment(R.layout.dialog_change_note
488488
lifecycleScope.launch {
489489
viewModel.canChangeTemplatesFlow.collect { canChangeTemplates ->
490490
binding.templatesContainer.isVisible = canChangeTemplates
491-
binding.templatesContainer.isVisible = canChangeTemplates
491+
binding.templatesHeaderLayout.isVisible = canChangeTemplates
492+
if (!canChangeTemplates) {
493+
binding.templateRemovalText.isVisible = false
494+
}
492495
}
493496
}
494497

495498
lifecycleScope.launch {
496499
viewModel.discardedTemplatesFlow.collect { discarded ->
497-
showDiscardedTemplatesMessage(discarded)
500+
if (viewModel.canChangeTemplatesFlow.value) {
501+
showDiscardedTemplatesMessage(discarded)
502+
}
498503
}
499504
}
500505
}

0 commit comments

Comments
 (0)