feat: classify undecided storage as a startup failure

Assisted-by: Claude Fable 5
Co-authored-by: Ashish Yadav <48384865+criticalAY@users.noreply.github.com>

Author: 2 people

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -82,6 +82,7 @@ import com.ichi2.anki.InitialActivity.StartupFailure.DirectoryNotAccessible
 import com.ichi2.anki.InitialActivity.StartupFailure.DiskFull
 import com.ichi2.anki.InitialActivity.StartupFailure.FutureAnkidroidVersion
 import com.ichi2.anki.InitialActivity.StartupFailure.SDCardNotMounted
+import com.ichi2.anki.InitialActivity.StartupFailure.StorageUndecided
 import com.ichi2.anki.IntentHandler.Companion.intentToReviewDeckFromShortcuts
 import com.ichi2.anki.account.AccountActivity
 import com.ichi2.anki.analytics.UsageAnalytics
@@ -1028,6 +1029,11 @@ open class DeckPicker :
             is StartupFailure.InitializationError -> FatalErrorDialog.build(this, failure).show()
             is DiskFull -> displayNoStorageError()
             is DBError -> displayDatabaseFailure(CustomExceptionData.fromException(failure.exception))
+            is StorageUndecided -> {
+                Timber.i("Displaying storage setup required")
+                // unreachable: storageDecision() cannot yet return Undecided outside tests
+                TODO("#19552 - replace with the storage setup flow.")
+            }
         }
     }
 

AnkiDroid/src/main/java/com/ichi2/anki/InitialActivity.kt

@@ -37,6 +37,7 @@ import com.ichi2.anki.servicelayer.PreferenceUpgradeService
 import com.ichi2.anki.servicelayer.PreferenceUpgradeService.setPreferencesUpToDate
 import com.ichi2.anki.servicelayer.ScopedStorageService.isLegacyStorage
 import com.ichi2.anki.storage.AnkiDroidFolder
+import com.ichi2.anki.storage.StorageDecision
 import com.ichi2.anki.ui.windows.permissions.InternetPermissionFragment
 import com.ichi2.anki.ui.windows.permissions.NotificationsPermissionFragment
 import com.ichi2.anki.ui.windows.permissions.PermissionsFragment
@@ -61,6 +62,13 @@ object InitialActivity {
             return StartupFailure.InitializationError(it)
         }
 
+        // Opening the collection would throw a StorageNotConfiguredException, which is not worth
+        // a crash report
+        if (CollectionHelper.storageDecision() != StorageDecision.Decided) {
+            Timber.i("storage location is undecided")
+            return StartupFailure.StorageUndecided
+        }
+
         val failure =
             try {
                 CollectionManager.getColUnsafe()
@@ -187,6 +195,13 @@ object InitialActivity {
         }
 
         data object DiskFull : StartupFailure()
+
+        /**
+         * The user has not yet decided where the collection is stored.
+         *
+         * @see CollectionHelper.storageDecision
+         */
+        data object StorageUndecided : StartupFailure()
     }
 }
 

AnkiDroid/src/test/java/com/ichi2/anki/StorageDecisionGateTest.kt

@@ -7,6 +7,7 @@ import com.ichi2.anki.exception.StorageNotConfiguredException
 import com.ichi2.anki.storage.StorageDecision
 import org.junit.Test
 import org.junit.runner.RunWith
+import kotlin.test.assertEquals
 import kotlin.test.assertFailsWith
 
 /**
@@ -25,4 +26,16 @@ class StorageDecisionGateTest : RobolectricTest() {
             CollectionHelper.storageDecisionTestOverride = null
         }
     }
+
+    /** No collection access should be attempted: a crash report would otherwise be generated */
+    @Test
+    fun `startup failure is StorageUndecided when storage is undecided`() {
+        CollectionHelper.storageDecisionTestOverride = StorageDecision.Undecided
+        try {
+            val failure = InitialActivity.getStartupFailureType { true }
+            assertEquals(InitialActivity.StartupFailure.StorageUndecided, failure)
+        } finally {
+            CollectionHelper.storageDecisionTestOverride = null
+        }
+    }
 }