refactor(deck-picker): right click menu

* remove unnecessary state
* define 'show' which handles DeckPicker specific logic

more verbose, but easier to understand

Assisted-by: Claude Opus 4.6

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -98,7 +98,6 @@ import com.ichi2.anki.common.time.TimeManager
 import com.ichi2.anki.common.utils.annotation.KotlinCleanup
 import com.ichi2.anki.compat.CompatHelper.Companion.getSerializableCompat
 import com.ichi2.anki.contextmenu.DeckPickerMenuContentProvider
-import com.ichi2.anki.contextmenu.MouseContextMenuHandler
 import com.ichi2.anki.databinding.ActivityHomescreenBinding
 import com.ichi2.anki.databinding.IncludeDeckPickerBinding
 import com.ichi2.anki.databinding.IncludeFloatingAddButtonBinding
@@ -270,9 +269,6 @@ open class DeckPicker :
     private lateinit var deckListAdapter: DeckAdapter
     private lateinit var pullToSyncWrapper: SwipeRefreshLayout
 
-    // Right-click context menu handler using decoupled menu system
-    private lateinit var mouseContextMenuHandler: MouseContextMenuHandler
-
     private lateinit var floatingActionMenu: DeckPickerFloatingActionMenu
 
     var activeSnackBar: Snackbar? = null
@@ -463,10 +459,13 @@ open class DeckPicker :
         y: Float,
     ) = launchCatchingTask {
         withCol { decks.select(deckId) }
-        val menuContentProvider = DeckPickerMenuContentProvider.newInstance(deckId, this@DeckPicker)
         updateDeckList()
-        mouseContextMenuHandler = MouseContextMenuHandler(deckPickerBinding.deckPickerContent, menuContentProvider)
-        mouseContextMenuHandler.showContextMenu(deckPickerBinding.decks, x, y)
+        DeckPickerMenuContentProvider.show(
+            deckPicker = this@DeckPicker,
+            deckId = deckId,
+            x = x,
+            y = y,
+        )
     }
 
     // ----------------------------------------------------------------------------

AnkiDroid/src/main/java/com/ichi2/anki/contextmenu/DeckPickerMenuContentProvider.kt

@@ -63,21 +63,30 @@ class DeckPickerMenuContentProvider(
 
     companion object {
         /**
-         * Builds a [DeckPickerMenuContentProvider] for [deckId], reading the dynamic /
-         * has-buried flags from the collection.
+         * Builds a [DeckPickerMenuContentProvider] for [deckId] (reading the dynamic /
+         * has-buried flags from the collection) and shows it as a popup anchored at
+         * ([x], [y]) on the deck picker's recycler view.
          */
-        suspend fun newInstance(
-            deckId: DeckId,
+        suspend fun show(
             deckPicker: DeckPicker,
-        ): DeckPickerMenuContentProvider =
-            withCol {
-                DeckPickerMenuContentProvider(
-                    id = deckId,
-                    isDynamic = decks.isFiltered(deckId),
-                    hasBuriedInDeck = sched.haveBuried(),
-                    deckPicker = deckPicker,
-                )
-            }
+            deckId: DeckId,
+            x: Float,
+            y: Float,
+        ) {
+            val provider =
+                withCol {
+                    DeckPickerMenuContentProvider(
+                        id = deckId,
+                        isDynamic = decks.isFiltered(deckId),
+                        hasBuriedInDeck = sched.haveBuried(),
+                        deckPicker = deckPicker,
+                    )
+                }
+            val anchorParent = deckPicker.deckPickerBinding.deckPickerContent
+            val target = deckPicker.deckPickerBinding.decks
+            MouseContextMenuHandler(viewGroup = anchorParent, menuContentProvider = provider)
+                .showContextMenu(view = target, x = x, y = y)
+        }
 
         fun createOptionsList(
             isDynamic: Boolean,