refactor: extract 'Directory.kt' to common module

This allows us to break a circular dependency in `:compat` tests
so they can be moved into the module

Assisted by Claude Opus 4.6
  - Plan by me, execution by Claude

Issue 20547

Author: david-allison

AnkiDroid/src/test/java/com/ichi2/anki/model/DirectoryTest.kt

@@ -16,6 +16,7 @@
 
 package com.ichi2.anki.model
 
+import com.ichi2.anki.compat.hasFiles
 import com.ichi2.compat.Test21And26
 import com.ichi2.testutils.HamcrestUtils.containsInAnyOrder
 import com.ichi2.testutils.withTempFile

…n/java/com/ichi2/anki/model/Directory.kt …n/java/com/ichi2/anki/model/Directory.ktAnkiDroid/src/main/java/com/ichi2/anki/model/Directory.kt renamed to common/src/main/java/com/ichi2/anki/model/Directory.kt AnkiDroid/src/main/java/com/ichi2/anki/model/Directory.kt renamed to common/src/main/java/com/ichi2/anki/model/Directory.kt

@@ -16,10 +16,7 @@
 
 package com.ichi2.anki.model
 
-import com.ichi2.anki.compat.CompatHelper
 import java.io.File
-import java.io.IOException
-import java.nio.file.NotDirectoryException
 
 /**
  * A directory which is assumed to exist (existed when class was instantiated)
@@ -30,21 +27,6 @@ class Directory private constructor(
     /** List of files in this directory. If this is not a directory or no longer exists, then an empty array. */
     fun listFiles(): Array<out File> = directory.listFiles() ?: emptyArray()
 
-    /**
-     * Whether this directory has at least files
-     * @return Whether the directory has file.
-     * @throws [SecurityException] If a security manager exists and its SecurityManager.checkRead(String)
-     * method denies read access to the directory
-     * @throws [java.io.FileNotFoundException] if the file do not exists
-     * @throws [NotDirectoryException] if the file could not otherwise be opened because it is not
-     * a directory (optional specific exception), (starting at API 26)
-     * @throws [IOException] – if an I/O error occurs.
-     * This also occurred on an existing directory because of permission issue
-     * that we could not reproduce. See https://github.com/ankidroid/Anki-Android/issues/10358
-     */
-    @Throws(IOException::class, SecurityException::class, NotDirectoryException::class)
-    fun hasFiles(): Boolean = CompatHelper.compat.hasFiles(directory)
-
     /** The [canonical path][java.io.File.getCanonicalPath] for the file */
     override fun toString(): String = directory.canonicalPath
 

compat/src/main/java/com/ichi2/anki/compat/DirectoryCompat.kt

@@ -0,0 +1,36 @@
+/*
+ *  Copyright (c) 2022 David Allison <davidallisongithub@gmail.com>
+ *
+ *  This program is free software; you can redistribute it and/or modify it under
+ *  the terms of the GNU General Public License as published by the Free Software
+ *  Foundation; either version 3 of the License, or (at your option) any later
+ *  version.
+ *
+ *  This program is distributed in the hope that it will be useful, but WITHOUT ANY
+ *  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
+ *  PARTICULAR PURPOSE. See the GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License along with
+ *  this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.ichi2.anki.compat
+
+import com.ichi2.anki.model.Directory
+import java.io.IOException
+import java.nio.file.NotDirectoryException
+
+/**
+ * Whether this directory has at least one file
+ * @return Whether the directory has a file.
+ * @throws [SecurityException] If a security manager exists and its SecurityManager.checkRead(String)
+ * method denies read access to the directory
+ * @throws [java.io.FileNotFoundException] if the file does not exist
+ * @throws [NotDirectoryException] if the file could not otherwise be opened because it is not
+ * a directory (optional specific exception), (starting at API 26)
+ * @throws [IOException] if an I/O error occurs.
+ * This also occurred on an existing directory because of permission issue
+ * that we could not reproduce. See https://github.com/ankidroid/Anki-Android/issues/10358
+ */
+@Throws(IOException::class, SecurityException::class, NotDirectoryException::class)
+fun Directory.hasFiles(): Boolean = CompatHelper.compat.hasFiles(directory)