Skip to content

Commit 9d3a70f

Browse files
criticalAYdavid-allison
authored andcommitted
refactor: extract 'ManuallyReportedException' to :common
The class is a pure RuntimeException subclass with no Android dependencies, so it lives in :common rather than :common:android. Removes one more dependency on :AnkiDroid for feature module extraction.
1 parent 90ffcaf commit 9d3a70f

7 files changed

Lines changed: 7 additions & 9 deletions

File tree

AnkiDroid/src/main/java/com/ichi2/anki/AcraCrashReporter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ import com.ichi2.anki.common.crashreporting.CrashReporter.Companion.FEEDBACK_REP
3232
import com.ichi2.anki.common.crashreporting.CrashReporter.Companion.FEEDBACK_REPORT_ASK
3333
import com.ichi2.anki.common.crashreporting.CrashReporter.Companion.FEEDBACK_REPORT_KEY
3434
import com.ichi2.anki.common.crashreporting.CrashReporter.Companion.FEEDBACK_REPORT_NEVER
35+
import com.ichi2.anki.common.exception.ManuallyReportedException
3536
import com.ichi2.anki.common.time.TimeManager
36-
import com.ichi2.anki.exception.ManuallyReportedException
3737
import com.ichi2.anki.exception.UserSubmittedException
3838
import com.ichi2.anki.preferences.sharedPrefs
3939
import com.ichi2.anki.servicelayer.ThrowableFilterService

AnkiDroid/src/main/java/com/ichi2/anki/DayRolloverHandler.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import com.ichi2.anki.CollectionManager.withOpenColOrNull
3737
import com.ichi2.anki.android.AnkiBroadcastReceiver
3838
import com.ichi2.anki.common.coroutines.applicationScope
3939
import com.ichi2.anki.common.crashreporting.CrashReportService
40-
import com.ichi2.anki.exception.ManuallyReportedException
40+
import com.ichi2.anki.common.exception.ManuallyReportedException
4141
import com.ichi2.anki.libanki.EpochSeconds
4242
import com.ichi2.anki.libanki.sched.Scheduler
4343
import com.ichi2.anki.observability.ChangeManager

AnkiDroid/src/main/java/com/ichi2/anki/snackbar/Snackbars.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import com.google.android.material.snackbar.onAttachedToWindow2
2929
import com.ichi2.anki.BuildConfig
3030
import com.ichi2.anki.R
3131
import com.ichi2.anki.common.crashreporting.CrashReportService
32-
import com.ichi2.anki.exception.ManuallyReportedException
32+
import com.ichi2.anki.common.exception.ManuallyReportedException
3333
import com.ichi2.anki.showThemedToast
3434
import timber.log.Timber
3535

AnkiDroid/src/main/java/com/ichi2/anki/workarounds/AppLoadedFromBackupWorkaround.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import android.os.Process
2222
import com.ichi2.anki.AnkiDroidApp
2323
import com.ichi2.anki.R
2424
import com.ichi2.anki.common.crashreporting.CrashReportService
25-
import com.ichi2.anki.exception.ManuallyReportedException
25+
import com.ichi2.anki.common.exception.ManuallyReportedException
2626
import com.ichi2.anki.showThemedToast
2727
import com.ichi2.themes.Themes
2828
import timber.log.Timber

AnkiDroid/src/main/java/com/ichi2/utils/ImportUtils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ import com.ichi2.anki.R
3333
import com.ichi2.anki.common.annotations.NeedsTest
3434
import com.ichi2.anki.common.coroutines.applicationScope
3535
import com.ichi2.anki.common.crashreporting.CrashReportService
36+
import com.ichi2.anki.common.exception.ManuallyReportedException
3637
import com.ichi2.anki.common.time.TimeManager
3738
import com.ichi2.anki.compat.CompatHelper
3839
import com.ichi2.anki.dialogs.DialogHandler
3940
import com.ichi2.anki.dialogs.DialogHandlerMessage
4041
import com.ichi2.anki.dialogs.ImportDialog
41-
import com.ichi2.anki.exception.ManuallyReportedException
4242
import com.ichi2.anki.onSelectedCsvForImport
4343
import com.ichi2.anki.servicelayer.DebugInfoService
4444
import com.ichi2.anki.showImportDialog

AnkiDroid/src/main/java/com/ichi2/widget/DayRolloverAlarm.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ import com.ichi2.anki.CollectionManager.withOpenColOrNull
3030
import com.ichi2.anki.android.AnkiBroadcastReceiver
3131
import com.ichi2.anki.common.coroutines.applicationScope
3232
import com.ichi2.anki.common.crashreporting.CrashReportService
33+
import com.ichi2.anki.common.exception.ManuallyReportedException
3334
import com.ichi2.anki.common.time.TimeManager
34-
import com.ichi2.anki.exception.ManuallyReportedException
3535
import com.ichi2.anki.launchCatching
3636
import com.ichi2.anki.libanki.EpochMilliseconds
3737
import com.ichi2.anki.libanki.sched.Scheduler

AnkiDroid/src/main/java/com/ichi2/anki/exception/ManuallyReportedException.kt renamed to common/src/main/java/com/ichi2/anki/common/exception/ManuallyReportedException.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
* this program. If not, see <http://www.gnu.org/licenses/>.
1515
*/
1616

17-
package com.ichi2.anki.exception
18-
19-
import java.lang.RuntimeException
17+
package com.ichi2.anki.common.exception
2018

2119
/** An exception for manual reporting to ACRA */
2220
class ManuallyReportedException(

0 commit comments

Comments
 (0)