fix: remove unnecessary safe property access

these were non-null properties and do not need safe access,
it is flagged as a warning (which we fail on with -Werror)
in new kotlin

Author: mikehardy

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/TagLimitFragment.kt

@@ -132,8 +132,8 @@ class TagLimitFragment : DialogFragment() {
     override fun onStart() {
         super.onStart()
         lifecycleScope.launch {
-            binding.loadingViews?.isVisible = true
-            binding.contentViews?.isVisible = false
+            binding.loadingViews.isVisible = true
+            binding.contentViews.isVisible = false
             val customStudyDefaults = withCol { sched.customStudyDefaults(deckId) }
             binding.requireOneOrMoreCheckBox.isChecked =
                 customStudyDefaults.tagsList.any { tag -> tag.include }
@@ -143,8 +143,8 @@ class TagLimitFragment : DialogFragment() {
                 }
             tagsIncludedAdapter.tags = tags.toMutableList() // make a copy
             tagsExcludedAdapter.tags = tags.toMutableList() // make a copy
-            binding.loadingViews?.isVisible = false
-            binding.contentViews?.isVisible = true
+            binding.loadingViews.isVisible = false
+            binding.contentViews.isVisible = true
         }
     }
 

AnkiDroid/src/test/java/com/ichi2/anki/AnalyticsTest.kt

@@ -117,7 +117,7 @@ class AnalyticsTest {
 
                 // prepare analytics so we can inspect what happens
                 val spyHit = spy(ExceptionHit())
-                doReturn(spyHit).whenever(analytics)?.exception()
+                doReturn(spyHit).whenever(analytics).exception()
                 try {
                     UsageAnalytics.sendAnalyticsException(grandparentException, false)
                 } catch (e: Exception) {